Add invoice prefix input validation #391
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #390
Limited max length to 15 and added
pattern
attribute with regex to allow only latin letters and-
,_
.When contains not allowed characters, the red border appears:
There are some issues such as that when saving via the button and the prefix is invalid, the page will scroll to it, but not enough, and it will be hidden under the page header.
But during input the red border appears immediately, so it should be good enough for this admin setting.
At first I was thinking to simply delete/replace the not allowed characters during saving on the server side, but it could result in confusion and bad prefixes (not unique across the merchant instances), because the merchant would not notice it after saving + afaik currently there is no good way to show a noticeable error message after saving, and we do not validate anything else like this.