Use subtotal_tax instead of adding taxes ourselves #373
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #372
It seems like when we add product and discount taxes ourselves, we get 5.16 + 1.375 = rounded to 6.54 (maybe we need to round differently? Like down instead of up)
get_subtotal_taxreturns 6.53, not sure if it fixes the issue completely, but I guess using it is more correct anyway than calculating ourselves.I also checked when shipping tax is present, looks like it is not included in
get_subtotal_tax, so the same as it was before.I tried looking into the WC code about cart taxes/totals to figure out if we are doing something wrong in general, but not found anything useful so far. For rounding they seem to use the
upmode too.