Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only last payment token is available because a new customer is returned each time (PCP-3860) #2820

Conversation

Dinamiko
Copy link
Contributor

@Dinamiko Dinamiko commented Nov 21, 2024

We need to send customer_id when saving payment token so PayPal will return the same customer_id in the response.

Steps To Reproduce

  • Enable Vaulting for ACDC
  • Save an ACDC payment from My account / Payment methods / Add payment method
  • Save another ACDC payment
  • Check payment tokens
  • Add product to cart and go to Classic Checkout
  • Try place order using the first payment you saved
    • Error: There was an error processing your order

This PR ensures customer_id is sent if it exist when saving the payment, so the same customer_id will be returned and therefore multiple payments will be available under the same customer id.

@Dinamiko Dinamiko merged commit 44b8854 into trunk Nov 21, 2024
9 checks passed
@Dinamiko Dinamiko deleted the PCP-3860-only-last-payment-token-is-available-because-a-new-customer-is-returned-each-time branch November 21, 2024 16:07
@InpsydeNiklas InpsydeNiklas added this to the 2.9.5 milestone Nov 28, 2024
@Dinamiko Dinamiko mentioned this pull request Dec 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants