Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow customers to see and delete their saved payments in My Account. #274

Merged
merged 11 commits into from
Sep 24, 2021

Conversation

Dinamiko
Copy link
Contributor

@Dinamiko Dinamiko commented Sep 23, 2021

Relates to #268.

saved-payment.mp4

@Dinamiko Dinamiko requested a review from AlexP11223 September 23, 2021 13:36
}
}
}
} catch ( Exception $error ) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should log.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

private function is_payments_page(): bool {
global $wp;
$request = explode( '/', $wp->request );
if ( end( $request ) === 'ppcp-paypal-payment-tokens' ) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe should use parse_url?

I guess this will fail if e.g. there is ? or # at the end.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@Dinamiko Dinamiko requested a review from AlexP11223 September 23, 2021 15:12
@Dinamiko Dinamiko merged commit 0515bdf into trunk Sep 24, 2021
@Dinamiko Dinamiko deleted the PCP-288-vaulting-token-creation-fails branch September 24, 2021 07:28
@Dinamiko Dinamiko mentioned this pull request Sep 24, 2021
@isabellainpsyde isabellainpsyde added this to the Release 1.6.0 milestone Sep 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants