Webhook simulation #273
Merged
Webhook simulation #273
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexP11223
force-pushed
the
webhook-simulation
branch
from
af93743 to
dbe1c1e
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds #260
At first I was thinking to simply save the time of the last webhook and display it here, but then I figured out that we can detect the simulated webhook by the ID we get after the API request. So it is saved into options and checked in the webhook listener. This way we get a bit better UX and no confusing logs because of failed webhook verifications (simulated webhook cannot be verified).
The status is checked every 2 sec via ajax, after 30 sec it displays an error but still tries for the next 30 sec.
Peek.2021-09-23.10-32.mp4
If failed:
