Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Axo Block: Always display the Fastlane watermark in the includeAdditionalInfo mode (3778) #2690

Conversation

danieldudzic
Copy link
Collaborator

Description

Before this PR the Fastlane Watermark (under the email input) would display in the includeAdditionalInfo mode only for guest users.

This PR ensures that it always displays in the includeAdditionalInfo mode (including after performing the successful email lookup).

Steps to test

  1. Open the Block Checkout page with Fastlane enabled.
  2. Ensure the Watermark loading spinner displays on the right.
  3. Ensure the Watermark displays correctly in the includeAdditionalInfo mode both on load and after the (successful email lookup).

Screenshots

Before the lookup

Before After
Block_Checkout_–_WooCommerce_PayPal_Payments Block_Checkout_–_WooCommerce_PayPal_Payments

After the lookup

Before After
Block_Checkout_–_WooCommerce_PayPal_Payments Block_Checkout_–_WooCommerce_PayPal_Payments

…t in the includeAdditionalInfo mode. Also move the loading spinner to the right.
@InpsydeNiklas InpsydeNiklas added this to the 2.9.3 milestone Oct 11, 2024
@Dinamiko Dinamiko merged commit 7c74400 into trunk Oct 11, 2024
5 checks passed
@Dinamiko Dinamiko deleted the PCP-3778-axo-block-the-fastlane-watermark-under-the-email-input-should-always-display-the-more-info-icon branch October 11, 2024 12:53
@Dinamiko Dinamiko added the bug Something isn't working label Oct 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
AXO bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants