Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Google Pay: Fix button preview in the editor (3374) #2688

Conversation

danieldudzic
Copy link
Collaborator

Description

This PR adds an interim fix for the Google Pay button preview in the block editor.

Eventually, we need to migrate to the React Google Pay component.

Steps to test

  1. Ensure the Google Pay button preview works in the editor.
  2. Ensure the Google Pay functionality still works correctly in the Block Checkout.

Screenshots

Before After
Edit_Page_“Block_Checkout”_‹_WooCommerce_PayPal_Payments_—_WordPress Edit_Page_“Block_Checkout”_‹_WooCommerce_PayPal_Payments_—_WordPress-2

@InpsydeNiklas InpsydeNiklas added this to the 2.9.3 milestone Oct 11, 2024
@Dinamiko Dinamiko merged commit 469d42f into trunk Oct 11, 2024
5 checks passed
@Dinamiko Dinamiko deleted the PCP-3374-google-pay-button-not-displayed-in-the-word-press-editor-v2 branch October 11, 2024 12:54
@Dinamiko Dinamiko added the bug Something isn't working label Oct 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants