Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the PayPal icons instead of WC ones (3687) #2639

Conversation

Narek13
Copy link
Collaborator

@Narek13 Narek13 commented Sep 25, 2024

PR Description

The issue happens because the plugin relies on Woo icons and therefor the unsupported by Woo icons such as MyBank, Blik and Trustly will not be displayed. The PR will fix this by changing the logic to support PayPal custom icons for APM-s

Issue Description

Missing logo on block checkout page for APM-s MyBank, Blik and Trustly.

Steps to Test

  1. Set currency EUR (MyBank or Trustly) or PLN (Blik)
  2. Navigate to shop and add product to cart
  3. Navigate to block checkout page
  4. Set country (Italy → MyBank or Austria → Trustly or Poland → Blik)
  5. Observe no logos are showing for mention APM-s

@InpsydeNiklas InpsydeNiklas added this to the 2.9.3 milestone Oct 3, 2024
@Dinamiko Dinamiko merged commit a3ec172 into trunk Oct 3, 2024
9 checks passed
@Dinamiko Dinamiko deleted the PCP-3687-missing-logo-on-block-checkout-page-for-apm-s-my-bank-blik-and-trustly branch October 3, 2024 08:43
@Dinamiko Dinamiko added the bug Something isn't working label Oct 10, 2024
@Dinamiko Dinamiko mentioned this pull request Oct 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants