Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Button Unlinking PayPal Subscriptions plan does not showing for simple subscription (3688) #2618

Conversation

Dinamiko
Copy link
Contributor

@Dinamiko Dinamiko commented Sep 18, 2024

0bb7165 introduced an early return when "Connect to PayPal" not sent in the post request making _ppcp_enable_subscription_product meta never been updated and therefore Unlink button not shown.

This PR reverts that change updating the meta value when checkbox is unchecked.

Steps To Reproduce

  • Set Subscription mode to PayPal Subscription
  • Create a Simple Subscription product, connect it to plan and Publish
  • On same page uncheck checkbox Connect to PayPal and click on button Update
    • Observe button Unlink PayPal Subscription Plan is not showing

@InpsydeNiklas InpsydeNiklas added this to the 2.9.3 milestone Oct 3, 2024
@Dinamiko Dinamiko merged commit 9f7c6f5 into trunk Oct 3, 2024
9 checks passed
@Dinamiko Dinamiko deleted the PCP-3688-button-unlinking-pay-pal-subscriptions-plan-does-not-showing-for-simple-subscription branch October 3, 2024 08:44
@Dinamiko Dinamiko added the bug Something isn't working label Oct 10, 2024
@Dinamiko Dinamiko mentioned this pull request Oct 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants