Refactor for PSR-4 #235
Merged
Refactor for PSR-4 #235
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactoring of modules themselves was not necessary, because they were already following the new standard.
PSR-4 is much more robust and predictable. But to do this, a source root dir must be specified for every module. This could be done in the root file, but this is not very modular. Instead, now every module declares its own source root by using the amazing Composer Merge Plugin. This approach allows each module to also declare its own dependencies. Together, these changes allow modules to be easily extractable to separate pacakges when the need arises, and in general improves modularity significantly.
The WP containers don't seem to be used anywhere. There were imports, but they are not actually used it seems.
Now will use config instead of CLI values for most things. Will also show sniff codes.
This is the newest release, and is the first one that is compatible with PHP 8. Other changes are BC-breaking, but very very minor.
AlexP11223
reviewed
Aug 26, 2021
Sync `release/1.6.0` fixes into `trunk`.
Not sure if it matters which event we use, but at least we are subscribed to this one
…mulation-event Use CHECKOUT.ORDER.APPROVED for simulation
…aved-card-it-showed-an- Add authorization flow for saved credit cards
…ts-issues Update JS packages
…-vaulting-module Update packages on vaulting module
…onfiguration Fix Project Configuration
|
Reopening PR |
Dinamiko
approved these changes
Sep 30, 2021
Fix docker phpcs command and improve readme
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This extracts the changes related to PSR-4 refactoring from #120.