WooCommerce orders left in “Pending Payment” after a decline

[Dinamiko]

Description

WooCommerce orders left in “Pending Payment” after a decline.

Steps to test:

Use this filter to return a INSTRUMENT_DECLINED error in the response.

add_filter('ppcp_request_args', function ($args, $url){
    if (strpos($url,'capture') !== false) {
        $args['headers']['PayPal-Mock-Response'] = '{"mock_application_codes": "INSTRUMENT_DECLINED"}';
    }
    return $args;
}, 10, 2);

Changelog entry

WooCommerce orders left in “Pending Payment” after a decline. #222

[strangerkir]

Looks ok, but I have a few questions to be absolutely sure.

[strangerkir]

This should work, but I have some doubts about it.
The code below gives 3 tries, from what I can see, before suggesting the customer using another payment method. Does it make sense if the order is already marked as failed?
Another thing I'm not sure about is why it checks for the INSTRUMENT_DECLINED only? I know, it's out of the scope of this PR, but just want to make sure there will be no problems with it. It looks like the order will be marked as failed only in case of this error 🤔 Is it the expected result?

[Dinamiko]

Hi @strangerkir thanks for the feedback,

Regarding retrying, if payment is accepted on second or third try order status changes from failed to on-hold first and then to processing, I´ve checked and it works like so now.

About the INSTRUMENT_DECLINED only, I have just added failed order status to the other two failing cases, thanks for the hint :)