Fix unnecessary redirect #206
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When enabling gateway don't redirect to it's settings if plugin already is in onboarded state.
Steps to test:
Complete onboarding or fill out all the relevant API details.
Go to WooCommerce > Settings > Payments.
Scroll down to "PayPal" and make sure the toggle is in the disabled state.
Click the toggle and make sure there is no redirection to the gateway settings page and the gateway is enabled.
Go to the gateway settings and disconnect to return to the not onboarded state.
Return to WooCommerce > Settings > Payments.
Disable the PayPal gateway and try to enable it again.
Make sure this time you were redirected to the gateway settings.
Documentation
Changelog entry
Fix unneeded redirection when enabling payment gateway and setup is already done.
Closes #190.