Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect API credentials cause fatal error #187

Merged
merged 6 commits into from
Jul 12, 2021
Merged

Incorrect API credentials cause fatal error #187

merged 6 commits into from
Jul 12, 2021

Conversation

Dinamiko
Copy link
Contributor

@Dinamiko Dinamiko commented Jul 2, 2021

Description

Manually entering incorrect API information in the settings leads to a fatal error:
image-20210630-095926

Steps to test:

  1. Enter any credentials for manual connection for email, merchant ID, client ID & secret (random letters are ok)
  2. Save settings
  3. Fatal error will prevent opening the plugin settings

@Dinamiko Dinamiko requested a review from strangerkir July 2, 2021 10:38
strangerkir
strangerkir approved these changes Jul 2, 2021
View reviewed changes
Copy link
Contributor

@strangerkir strangerkir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@Dinamiko Dinamiko merged commit 2efb300 into trunk Jul 12, 2021
@Dinamiko Dinamiko deleted the PCP-179-incorrect-api-credentials-cause- branch July 12, 2021 09:41
@Dinamiko Dinamiko mentioned this pull request Jul 16, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@strangerkir strangerkir strangerkir approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Dinamiko @strangerkir