Filter PayPal-supported language codes #154
Conversation
| @@ -726,7 +726,7 @@ private function url(): string { | |||
| $params = array( | |||
| 'client-id' => $this->client_id, | |||
| 'currency' => get_woocommerce_currency(), | |||
| 'locale' => get_user_locale(), | |||
| 'locale' => $this->valid_locale_code(), | |||
There was a problem hiding this comment.
I'd suggest not pass the locale at all, as PayPal detects it automatically, and their advice (the locale parameter description in the table below) is to not use this parameter unless it's really needed.
But if we really need this, then it maybe makes sense to map possible WP locales to the ones accepted by PayPal. For example, when the Bulgarian language is set for the site, then the WP locale is bg_BG, but PayPal accepts en_BG only. A similar problem appears for the Belarus language, and should be for some others I haven't checked. I tested it, and in my case when the locale is not accepted by PayPal, the JS SDK script is not loaded. Instead, I've had HTTP error code 400.
| protected function valid_bcp47_code() { | ||
| $locale = str_replace( '_', '-', get_user_locale() ); | ||
| $parts = explode( '-', $locale ); | ||
|
|
||
| if ( count( $parts ) < 3 ) { | ||
| return $locale; | ||
| } | ||
|
|
||
| return substr( $locale, 0, strrpos( $locale, '-' ) ); | ||
| } |
There was a problem hiding this comment.
I have some doubts about this. I believe this will work in most cases but I expect it fail when get_user_locale() returns locale containing 3 letters with no delimiter (like bel when Belarusian site language is chosen, also ceb for Cebuano, ary, dsb, etc.).
PayPal documentation states they use the ^[a-z]{2}(?:-[A-Z][a-z]{3})?(?:-(?:[A-Z]{2}))?$ regex to validate the language. I tested a few of possible WP locales and it worked for the xx-XX format (like de-DE), also for xx format (like ar), but not for xxx format (like the bel and others I provided above). This function will return three-letters code as is (which is valid BCP 47, if I understand it correctly). But it doesn't meet the regex from PayPal docs provided above.
I have no good suggestion about this issue. Probably, it would make sense to use that regex to validate the result and fallback to default if validation wasn't passed.
|
Hi @strangerkir, I´ve removed |
Description
When selecting a language in WordPress like German [formal] or Norsk [Bokmål] banners and buttons do not appear on the selected pages and also there will be an error after trying to buy a product on the checkout page.
Steps to test: