Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix pay later messaging options #141

Merged
merged 6 commits into from
May 26, 2021

Conversation

strangerkir
Copy link
Contributor

@strangerkir strangerkir commented Mar 31, 2021

Issue: PCP-113.


Description

Pay Later messaging settings are contained fields related to two types of layout: text and flex. At any moment only one type of field should be displayed, depending on what selected, text or flex.

Steps to test:

  1. Log into WP admin.
  2. Go to the plugin settings.
  3. Enable Pay Later messaging (if not enabled).
  4. Check what type of layout is selected.
  5. Make sure that only respective options are displayed below the layout select field. For Text: logo, logo position, text color. For Flex: color and ratio. Also, WC help tips next to each field contain info on what type of layout this setting relates to.
  6. Try to check/uncheck PayLater messages and save. Make sure the proper fields are displayed each time and no fields displayed if PayLater messaging is disabled.
  7. Try to switch layout and save. Make sure you can see proper fields.

Note: There are three sets of settings fields related to Pay Later messages: for checkout, for cart, and for product page. They have the same fields and the same appearance logic described above.

Documentation

  • This PR needs documentation (has the "Documentation" label).

Changelog entry

Enter a summary of all changes on this Pull Request. This will appear in the changelog if accepted.

  • Fix - Pay Later settings appearance based on selected layout type.

Closes #138.

@strangerkir strangerkir marked this pull request as ready for review April 8, 2021 05:04
@Dinamiko Dinamiko merged commit 6d34c53 into trunk May 26, 2021
@Dinamiko Dinamiko deleted the PCP-113-fix-pay-later-messaging-options branch May 26, 2021 08:26
@Dinamiko Dinamiko mentioned this pull request Jun 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

When enabling Pay Later messages, settings for both layouts (text/flex) are being shown simultaneously
2 participants