Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Shipping Labels - Customs Form] UI 3 - Information Dialogs & Countries #14770

Draft
wants to merge 4 commits into
base: issue/13784-shipping-labels-customs-form-2
Choose a base branch
from

Conversation

toupper
Copy link
Contributor

@toupper toupper commented Dec 27, 2024

Part of: #13784

Description

With this PR we implement the information dialogs in the customs form. Given the length of the description text and the fact that it contains a button, I decided to add a sheet with a custom dialog as we do in other parts of the app. I repeated the process for the Origin Country information dialog.

Steps to reproduce

  1. Go to orders
  2. Tap on a complete order which can render a shipping label
  3. Tap on Create Shipping Label
  4. Tap on the Customs pencil button
  5. Expand the dummy product detail row
  6. Tap on the info button for the description and the origin country
  7. See that the information dialogs are created. In case of the description, the learn more button links to the web view.
  8. Tap on the Origin Country Menu. See that a sheet list is shown with all the countries, and the selection is shown in the Product Details.

Testing information

N/A

Screenshots

Simulator.Screen.Recording.-.iPhone.16.-.2024-12-27.at.13.37.49.mp4

  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

Reviewer (or Author, in the case of optional code reviews):

Please make sure these conditions are met before approving the PR, or request changes if the PR needs improvement:

  • The PR is small and has a clear, single focus, or a valid explanation is provided in the description. If needed, please request to split it into smaller PRs.
  • Ensure Adequate Unit Test Coverage: The changes are reasonably covered by unit tests or an explanation is provided in the PR description.
  • Manual Testing: The author listed all the tests they ran, including smoke tests when needed (e.g., for refactorings). The reviewer confirmed that the PR works as expected on all devices (phone/tablet) and no regressions are added.

@toupper toupper added type: task An internally driven task. feature: shipping labels Related to creating, ordering, or printing shipping labels. labels Dec 27, 2024
@toupper toupper added this to the 21.4 milestone Dec 27, 2024
@wpmobilebot
Copy link
Collaborator

wpmobilebot commented Dec 27, 2024

WooCommerce iOS📲 You can test the changes from this Pull Request in WooCommerce iOS by scanning the QR code below to install the corresponding build.

App NameWooCommerce iOS WooCommerce iOS
Build Numberpr14770-1fd7542
Version21.3
Bundle IDcom.automattic.alpha.woocommerce
Commit1fd7542
App Center BuildWooCommerce - Prototype Builds #12319
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@toupper toupper changed the title [Shipping Labels - Customs Form] UI 3 - Information Dialogs [Shipping Labels - Customs Form] UI 3 - Information Dialogs & Countries Dec 27, 2024
@toupper toupper marked this pull request as draft December 27, 2024 16:31
@dangermattic
Copy link
Collaborator

1 Message
📖 This PR is still a Draft: some checks will be skipped.

Generated by 🚫 Danger

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature: shipping labels Related to creating, ordering, or printing shipping labels. type: task An internally driven task.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants