Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attempt at fixing the Github screenshots workflow #14556

Draft
wants to merge 7 commits into
base: trunk
Choose a base branch
from

Conversation

hichamboushaba
Copy link
Member

Closes: #

Description

Steps to reproduce

Testing information

Screenshots


  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

Reviewer (or Author, in the case of optional code reviews):

Please make sure these conditions are met before approving the PR, or request changes if the PR needs improvement:

  • The PR is small and has a clear, single focus, or a valid explanation is provided in the description. If needed, please request to split it into smaller PRs.
  • Ensure Adequate Unit Test Coverage: The changes are reasonably covered by unit tests or an explanation is provided in the PR description.
  • Manual Testing: The author listed all the tests they ran, including smoke tests when needed (e.g., for refactorings). The reviewer confirmed that the PR works as expected on all devices (phone/tablet) and no regressions are added.

@hichamboushaba hichamboushaba added type: task An internally driven task. status: do not merge Dependent on another PR, ready for review but not ready for merge. generate screenshots Triggers a GitHub Action to generate screenshots for this PR. labels Nov 28, 2024
@hichamboushaba hichamboushaba changed the base branch from trunk to task/fix-screenshots November 28, 2024 16:29
@dangermattic
Copy link
Collaborator

1 Message
📖 This PR is still a Draft: some checks will be skipped.

Generated by 🚫 Danger

@wpmobilebot
Copy link
Collaborator

wpmobilebot commented Nov 28, 2024

WooCommerce iOS📲 You can test the changes from this Pull Request in WooCommerce iOS by scanning the QR code below to install the corresponding build.

App NameWooCommerce iOS WooCommerce iOS
Build Numberpr14556-6b6f6ea
Version21.2
Bundle IDcom.automattic.alpha.woocommerce
Commit6b6f6ea
App Center BuildWooCommerce - Prototype Builds #11876
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@hichamboushaba hichamboushaba force-pushed the task/fix-screenshots-github-action branch 2 times, most recently from 9a504d5 to a21d689 Compare November 29, 2024 09:49
@hichamboushaba hichamboushaba force-pushed the task/fix-screenshots-github-action branch from a21d689 to fb22ce2 Compare November 29, 2024 15:09
Base automatically changed from task/fix-screenshots to trunk November 29, 2024 15:57
@hichamboushaba hichamboushaba force-pushed the task/fix-screenshots-github-action branch from fb22ce2 to 6b6f6ea Compare November 29, 2024 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
generate screenshots Triggers a GitHub Action to generate screenshots for this PR. status: do not merge Dependent on another PR, ready for review but not ready for merge. type: task An internally driven task.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants