Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

World's worst HACK week code – Remote Tap to Pay on iPhone #14065

Open
wants to merge 6 commits into
base: trunk
Choose a base branch
from

Conversation

joshheald
Copy link
Contributor

Closes: Nothing. Never merge this. Not even a bit.

Description

This is a hack week project. Don't merge it, don't judge it, ideally don't even read it, it's just cool that it works.
I've used some of Apple's sample networking code

Testing information

Hahahahaha good luck.

  1. Launch the app on an iPhone, and sign out if you're not already.
  2. Tap Remote Tap to Pay on the final Login prologue screen – you might need to tap skip a few times to get to this.
  3. Launch the app on an iPad and switch to a POS eligible store
  4. Tap Connect your reader and choose remote tap to pay
  5. Do it again if it doesn't work the first time
  6. Add something to your cart and checkout as normal
  7. Tap your card on the iPhone
  8. Observe that the payment completes
  9. Do a little dance
  10. Never read the code.

This can connect to the TTP reader on a phone and collect a payment with it, but it can’t reconnect to the iPad and then complete the payment.

The connection is interrupted when the app is backgrounded for the TTP payment
This is awful. Never merge this.
@joshheald joshheald added the status: do not merge Dependent on another PR, ready for review but not ready for merge. label Sep 27, 2024
@dangermattic
Copy link
Collaborator

2 Errors
🚫 This PR is tagged with status: do not merge label(s).
🚫 PR is not assigned to a milestone.
2 Warnings
⚠️ View files have been modified, but no screenshot or video is included in the pull request. Consider adding some for clarity.
⚠️ This PR is larger than 300 lines of changes. Please consider splitting it into smaller PRs for easier and faster reviews.

Generated by 🚫 Danger

@wpmobilebot
Copy link
Collaborator

WooCommerce iOS📲 You can test the changes from this Pull Request in WooCommerce iOS by scanning the QR code below to install the corresponding build.

App NameWooCommerce iOS WooCommerce iOS
Build Numberpr14065-e8c2678
Version20.5
Bundle IDcom.automattic.alpha.woocommerce
Commite8c2678
App Center BuildWooCommerce - Prototype Builds #11046
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: do not merge Dependent on another PR, ready for review but not ready for merge.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants