-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[HACK week] Product list - Add favorite product filter option #13995
Conversation
📲 You can test the changes from this Pull Request in WooCommerce iOS by scanning the QR code below to install the corresponding build.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested this both in off and on feature flag state, and in the on state I tested all the cases including by killing the app and returning. I can confirm that everything works fine. The code is also following the existing filtering logic, so all good.
Aside:
While looking at the Filter screen, since Favorite Product is inherently a boolean, I wonder if it's better UI-wise to make it a toggle, instead of navigating to another screen to select. It wil save time, at least.
That is unrelated to this PR, though.
Thanks for the review.
Good suggestion, Hafiz! Logged it as a subtask under enhancements #12274 |
Part of: #12274
Description
Start showing a new filter option in the product list filter screen.
The selection is persisted to storage and loaded again.
Changes
FavoriteProductsFilter
filter for filtering favorite products.Steps to reproduce
Prerequisites
Feature flag off
Feature flag on
favoriteProducts
feature flag by returningtrue
from hereTesting information
Screenshots
RELEASE-NOTES.txt
if necessary.Reviewer (or Author, in the case of optional code reviews):
Please make sure these conditions are met before approving the PR, or request changes if the PR needs improvement: