Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ACSS LPM feature flag #3785

Merged
merged 1 commit into from
Jan 29, 2025
Merged

Add ACSS LPM feature flag #3785

merged 1 commit into from
Jan 29, 2025

Conversation

ricardo
Copy link
Member

@ricardo ricardo commented Jan 28, 2025

Fixes #3781

Changes proposed in this Pull Request:

Similar to #3745 and #3754, introduce a new _wcstripe_feature_lpm_acss feature flag for testing the ACSS / Canadian Pre-Authorized Debit LPM.

Testing instructions

  • Switch to this branch.

Enable ACSS

  1. Enable the feature flag with npm run wp option update _wcstripe_feature_lpm_acss 'yes'.
  2. Navigate to the Stripe gateway settings page and ensure window.wc_stripe_settings_params.is_acss_enabled evaluates to '1'.
  3. Navigate to cart or checkout page and ensure window.wc_stripe_upe_params.is_acss_enabled evaluates to '1'.

Disable ACSS

  1. Disable the feature flag with npm run wp option delete _wcstripe_feature_lpm_acss.
  2. Navigate to the Stripe gateway settings page and ensure window.wc_stripe_settings_params.is_acss_enabled evaluates to ''.
  3. Navigate to cart or checkout page and ensure window.wc_stripe_upe_params.is_acss_enabled evaluates to ''.

  • Covered with tests (or have a good reason not to test in description ☝️)
  • Added changelog entry in both changelog.txt and readme.txt (or does not apply)
  • Tested on mobile (or does not apply)

Post merge

@ricardo ricardo requested review from a team and cesarcosta99 and removed request for a team January 28, 2025 14:35
Copy link
Contributor

@cesarcosta99 cesarcosta99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and tests well!

@ricardo ricardo merged commit 941c26b into develop Jan 29, 2025
35 of 37 checks passed
@ricardo ricardo deleted the add/3781-acss-feature-flag branch January 29, 2025 01:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ACSS: Add Feature Flag
2 participants