This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 219
Run unit tests depending on the files changed in the PR (JS | PHP) #9835
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kmanijak
added
skip-changelog
PRs that you don't want to appear in the changelog.
tool: monorepo infrastructure
Pull requests that update GitHub Actions code.
labels
Jun 15, 2023
The release ZIP for this PR is accessible via:
Script Dependencies ReportThere is no changed script dependency between this branch and trunk. This comment was automatically generated by the TypeScript Errors Report
🎉 🎉 This PR does not introduce new TS errors. |
kmanijak
changed the title
L:imits PHP Unit Tests to PRs changing .php files
Limit PHP Unit Tests to PRs changing .php files
Jun 15, 2023
Size Change: 0 B Total Size: 1.1 MB ℹ️ View Unchanged
|
1 task
kmanijak
changed the title
Limit PHP Unit Tests to PRs changing .php files
Run unit tests depending on the files changed in the PR (JS | PHP)
Jun 15, 2023
We won't follow this approach, hence closing. In the meantime the tests for PHP 8.1 and 8.2 were temporarily disabled: #9859 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
skip-changelog
PRs that you don't want to appear in the changelog.
tool: monorepo infrastructure
Pull requests that update GitHub Actions code.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, PHP Unit Tests jobs are failing on every PR. This is most likely due the official WordPress docker images being recently updated (e.g. WordPress 8.2 image) and are now based on debian:12-slim.
That change affected multiple repositories, Gutenberg included. The fix was provided to the
@wordpress/env
package that unblocks the pipelines for Gutenberg'strunk
, but the change is not released yet, hence we cannot update wp-env and have no control over docker-image to apply the changes manually.Having said that, this PR limits the:
*.php
files only, which is not a fix, but allows the other PRs to pass with green pipelines.*.js, *.ts, *.jsx, *tsx
files only.Additonally, all unit tests are fired for tags and
trunk
branch.User Facing Testing