This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
Avoid exposing receiveCart to extensions #4730
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Aljullu
added
status: needs review
type: bug
|
Size Change: +96 B (0%) Total Size: 1.19 MB
ℹ️ View Unchanged
|
senadir
approved these changes
Sep 13, 2021
| @@ -150,7 +150,7 @@ const ShippingRatesControl = ( { | |||
| // Prepare props to pass to the ExperimentalOrderShippingPackages slot fill. | |||
| // We need to pluck out receiveCart. | |||
| // eslint-disable-next-line no-unused-vars | |||
| const { extensions, ...cart } = useStoreCart(); | |||
There was a problem hiding this comment.
This was already removed (according to the comment) so it seems like it slipped in by accident on a recent refactor. Great catch!
github-actions
bot
added
status: ready to merge
and removed
status: needs review
labels
I did think about that, we have a pattern of doing that recently, e.g. |
|
Makes sense. Thanks for the review @senadir! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working on #4688, I found a couple of instances where we were passing
receiveCartto slot fills so it was available by extensions. This PR fixes that.Question: I wonder if we should create a hook that acts as a wrapper of
useStoreCart()and automatically excludesreceiveCart, so it can be used safely when making data available to extensions.Testing
Changelog