This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
Disable Cart, Checkout, All Products & filters blocks from the widgets screen #4646
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Aljullu
added
status: needs review
status: blocker
|
Size Change: 0 B Total Size: 1.19 MB ℹ️ View Unchanged
|
The question for me is whether another ~1.5 months wait is too long for this UX regression (and potential additional confusion for end users). Might be good to bring it up with the WC 5.7 release team and get their thoughts as well. |
Aljullu
added
block: all products
frontdevde
approved these changes
Aug 30, 2021
There was a problem hiding this comment.
Thanks for addressing this so quickly! ❤️
I tested as per testing instructions and can confirm:
- The blocks aren't available in the inserter in Appearance > Widgets
- The blocks aren't available in the inserter in the Customizer
- The blocks are available in the inserter on posts and pages
LGTM 👍
github-actions
bot
added
status: ready to merge
and removed
status: needs review
labels
Aljullu
added a commit
that referenced
this pull request
Aug 30, 2021
Aljullu
added
the
release: cherry-pick
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4640.
Regression from #3737. Currently, we are relying on a work-around to prevent some blocks being added to widget areas until a Gutenberg-supported solution is implemented (see WordPress/gutenberg#28517). It works detecting which is the current screen and based on that not registering some blocks.
Adding this PR to the 5.8 milestone and with label
blockerbecause I consider this regression to be important enough. I'm on the fence on whether this deserves a point release of WC Blocks 5.7 and WC core 5.7. Thoughts @nerrad @frontdevde?I also created an issue to add automated testing for this so we can detect if this work-around stops working in the future: #4645.
How to test the changes in this Pull Request:
With Storefront and WP 5.8:
Changelog