Skip to content
This repository has been archived by the owner on Feb 23, 2024. It is now read-only.

Make sure payment method assets are loaded in block editor #2075

Merged
merged 1 commit into from
Mar 31, 2020

Conversation

nerrad
Copy link
Contributor

@nerrad nerrad commented Mar 31, 2020

As a part of the work in #1983, I split out the payment method extension registration into it's own built bundle to more closely replicate how payment extensions would be hooking into the payment method api.

I realized today that in the process I broke the payment method integration in the block editor context as the script was not getting enqueued in the editor.

This pull fixes that.

To Test

  • Verify that with stripe configured, you see it show up in the editor and in the frontend for the checkout block.
  • Verify that when you add a new checkout block in a new editor instance that the payment method integration shows up.

@nerrad nerrad requested a review from a team as a code owner March 31, 2020 11:46
@nerrad nerrad requested review from Aljullu and removed request for a team March 31, 2020 11:46
@nerrad nerrad self-assigned this Mar 31, 2020
@nerrad nerrad added type: bug The issue/PR concerns a confirmed bug. skip-changelog PRs that you don't want to appear in the changelog. labels Mar 31, 2020
@nerrad nerrad added this to the Future Release milestone Mar 31, 2020
@github-actions
Copy link
Contributor

Size Change: 0 B

Total Size: 2.15 MB

ℹ️ View Unchanged
Filename Size Change
build/active-filters-frontend.js 7.54 kB 0 B
build/active-filters.js 8.29 kB 0 B
build/all-products-frontend.js 17.3 kB 0 B
build/all-products.js 66.2 kB 0 B
build/all-reviews-legacy.js 10.8 kB 0 B
build/all-reviews.js 11 kB 0 B
build/attribute-filter-frontend.js 17 kB 0 B
build/attribute-filter.js 11.8 kB 0 B
build/block-error-boundary-legacy.js 774 B 0 B
build/block-error-boundary.js 774 B 0 B
build/blocks-legacy.js 2.92 kB 0 B
build/blocks.js 2.92 kB 0 B
build/cart-frontend.js 158 kB 0 B
build/cart.js 75.5 kB 0 B
build/checkbox-control-style-legacy.js 779 B 0 B
build/checkbox-control-style.js 781 B 0 B
build/checkout-frontend.js 164 kB 0 B
build/checkout.js 78 kB 0 B
build/custom-select-control-style-legacy.js 782 B 0 B
build/custom-select-control-style.js 783 B 0 B
build/editor-legacy-rtl.css 12.6 kB 0 B
build/editor-legacy.css 12.6 kB 0 B
build/editor-rtl.css 13.5 kB 0 B
build/editor.css 13.5 kB 0 B
build/featured-category-legacy.js 146 kB 0 B
build/featured-category.js 146 kB 0 B
build/featured-product-legacy.js 59.5 kB 0 B
build/featured-product.js 59.4 kB 0 B
build/handpicked-products-legacy.js 7.31 kB 0 B
build/handpicked-products.js 7.51 kB 0 B
build/panel-style-legacy.js 773 B 0 B
build/panel-style.js 773 B 0 B
build/price-filter-frontend.js 14.1 kB 0 B
build/price-filter.js 10.4 kB 0 B
build/product-best-sellers-legacy.js 7.41 kB 0 B
build/product-best-sellers.js 7.62 kB 0 B
build/product-categories-legacy.js 3.2 kB 0 B
build/product-categories.js 3.19 kB 0 B
build/product-category-legacy.js 8.32 kB 0 B
build/product-category.js 8.53 kB 0 B
build/product-list-style-legacy.js 776 B 0 B
build/product-new-legacy.js 7.58 kB 0 B
build/product-new.js 7.78 kB 0 B
build/product-on-sale-legacy.js 7.92 kB 0 B
build/product-on-sale.js 8.18 kB 0 B
build/product-search-legacy.js 3.64 kB 0 B
build/product-search.js 3.86 kB 0 B
build/product-tag-legacy.js 6.48 kB 0 B
build/product-tag.js 6.68 kB 0 B
build/product-top-rated-legacy.js 7.55 kB 0 B
build/product-top-rated.js 7.75 kB 0 B
build/products-by-attribute-legacy.js 8.48 kB 0 B
build/products-by-attribute.js 8.68 kB 0 B
build/reviews-by-category-legacy.js 12.7 kB 0 B
build/reviews-by-category.js 13 kB 0 B
build/reviews-by-product-legacy.js 14.2 kB 0 B
build/reviews-by-product.js 14.5 kB 0 B
build/reviews-frontend-legacy.js 8.4 kB 0 B
build/reviews-frontend.js 9.09 kB 0 B
build/snackbar-notice-style-legacy.js 778 B 0 B
build/snackbar-notice-style.js 778 B 0 B
build/spinner-style-legacy.js 774 B 0 B
build/spinner-style.js 772 B 0 B
build/style-legacy-rtl.css 5.3 kB 0 B
build/style-legacy.css 5.31 kB 0 B
build/style-rtl.css 14.4 kB 0 B
build/style.css 14.4 kB 0 B
build/vendors-legacy.js 280 kB 0 B
build/vendors-style-legacy-rtl.css 1.97 kB 0 B
build/vendors-style-legacy.css 1.97 kB 0 B
build/vendors-style-legacy.js 110 B 0 B
build/vendors-style-rtl.css 1.97 kB 0 B
build/vendors-style.css 1.97 kB 0 B
build/vendors-style.js 109 B 0 B
build/vendors.js 367 kB 0 B
build/wc-blocks-data.js 6.64 kB 0 B
build/wc-blocks-registry.js 1.51 kB 0 B
build/wc-payment-method-extensions.js 109 kB 0 B
build/wc-settings.js 2.14 kB 0 B

compressed-size-action

@senadir senadir merged commit 213684a into master Mar 31, 2020
@senadir senadir deleted the fix/load-pm-assets-in-block-editor branch March 31, 2020 11:56
@nerrad nerrad modified the milestones: Future Release, 2.6.0 Apr 17, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
skip-changelog PRs that you don't want to appear in the changelog. type: bug The issue/PR concerns a confirmed bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants