This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
Add Checkout block sidebar #1921
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Aljullu
added
status: needs review
focus: components
Aljullu
force-pushed
the
add/checkout-sidebar
branch
2 times, most recently
from
0bae207 to
000a637
Compare
This was referenced Mar 11, 2020
nerrad
approved these changes
Mar 11, 2020
There was a problem hiding this comment.
Huge 👍 for extracting out the new sidebar components so that checkout and cart are both using them 👏
Functionally, this seems to work well. I noticed there's an error when applying an invalid coupon, but this also occurs in master so I'll go ahead and approve this.
Comment on lines
+62
to
+71
| total_items: '0', | ||
| total_items_tax: '0', | ||
| total_fees: '0', | ||
| total_fees_tax: '0', | ||
| total_discount: '0', | ||
| total_discount_tax: '0', | ||
| total_shipping: '0', | ||
| total_shipping_tax: '0', | ||
| total_price: '0', | ||
| total_tax: '0', |
Aljullu
force-pushed
the
add/checkout-sidebar
branch
from
000a637 to
1255a86
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #1304.
Part of #1486.
Screenshots
How to test the changes in this Pull Request: