This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
Add defaults for cart data totals object #1896
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikejolley
approved these changes
Mar 9, 2020
It mostly prevents having to do undefined/nullish checks on the property in consuming code (plus makes typescript linting happy). |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was first noticed and implemented as a part of #1780. Since cart.totals is a well-used data property, it is good to have it's shape defined in the default reducer state to prevent undefined errors when implementing.
To Test
This has zero impact on existing code as it's only adding a default expected shape (matching the shape that would get saved to the store). Still, a smoke test of loading the cart would be a good test to verify nothing is broken.