This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
Switch lint:js command to use wp-scripts and address errors. #1837
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working on #1780 I noticed that our linting command doesn't use
wp-scriptsand when I switched there were additional errors that popped up (because of the widened linting checks on files previously excluded). It's important to continue using wp-scripts for the lint command to ensure we get any improvements brought in by that.Since the changes don't impact any existing code and is verifiable via travis, I'll merge once Travis passes.