This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
Fix errors caused by demo payment methods #1547
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was introduced in #1349 . The way the demo payment method registration was setup, the react nodes were root native dom elements (
<div>
,<img />
) so whenReact.cloneElement
was called on them to pass in the checkout props, these props were then applied to the native nodes which in turn caused the React warnings due to camel-case props (isActive
,checkoutData
etc). The solution was to modify the demo elements so that they were custom react nodes (which is what actual payment methods will be doing anyways).To Test
View the console for the checkout block in the editor or on the frontend and there should be no warnings in the console.