This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add payment method api and components to checkout steps #1349
Add payment method api and components to checkout steps #1349
Changes from all commits
cef7a16
63a736d
6d7ca7f
959e545
55cb116
97c0f2f
fa99dc4
e96c670
a995c13
43a79a1
a02a07f
2b8da64
c95059f
d792316
f390e4f
864ad3a
aeadf14
c21db2a
6e9bd0d
8149971
f34dcc2
b8a3974
2ede9a5
6853d21
76ce412
c833a83
ae58ab4
c252929
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's the purpose of memoizing this function? Is it to preserve something in the payment method component?
If it's just to inject the
selectedTab
as a render prop, could we use a custom hook (eg:getSelectedTab
) instead?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably no need to memoize actually.
Hmm... I'm not sure I follow what you are suggesting here. Do you mean
useSelectedTab
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, um, yes. I think that is probably what I meant. 😅 Sorry.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
...but only in the editor. Might want to consider something for the frontend to communicate to customers that payments can't be completed?