This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
Tweak the product prompt #11903
Merged
Tweak the product prompt #11903
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To avoid creating products that are things that cannot be sold in stores (forests, people, etc.)
|
The release ZIP for this PR is accessible via: Script Dependencies ReportThere is no changed script dependency between this branch and trunk. This comment was automatically generated by the TypeScript Errors Report
🎉 🎉 This PR does not introduce new TS errors. |
|
Size Change: -4 B (0%) Total Size: 1.61 MB
ℹ️ View Unchanged
|
albarin
added
type: enhancement
woocommercebot
requested review from
a team and
tjcafferkey
and removed request for
a team
albarin
requested review from
gigitux and
nefeline
and removed request for
tjcafferkey
nefeline
approved these changes
Nov 27, 2023
There was a problem hiding this comment.
Great work! Tested with the following prompts:
I sell milk
A premier online destination for the latest electronic gadgets, offering everything from cutting-edge smartphones to innovative smart home devices, with expert reviews and tech support.
A paradise for book lovers, featuring a vast collection of books in various genres, including rare and out-of-print editions, with a community forum for discussions and book recommendations.
An online store dedicated to pet lovers, providing a variety of pet supplies, toys, and food for different animals, along with a pet adoption service and a blog for pet care tips.
I still see some instances where the product description doesn't necessarily describe what the business is selling, such as "Pots fence" for a pet supplies store or "Coffee Table Set" for a bookshop.
We still need to further investigate if it's possible to fine-tune these prompts to ensure the business description consistently takes priority over the image description, but can be done on a separate PR.
Regarding:
It also adds a condition to check the images param in the PatternUpdater to avoid a fatal error when calling the endpoint without any images:
[23-Nov-2023 08:42:10 UTC] PHP Fatal error: Uncaught TypeError: count(): Argument #1 ($value) must be of type Countable|array, null given in /public/wp-content/plugins/woocommerce-gutenberg-products-block-11877/src/Patterns/PatternUpdater.php:64
Nice catch!
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
This PR does some prompt fine-tuning to avoid creating products that are things that cannot be sold in stores (forests, people, etc.).
It also adds a condition to check the images param in the
PatternUpdaterto avoid a fatal error when calling the endpoint without any images:[23-Nov-2023 08:42:10 UTC] PHP Fatal error: Uncaught TypeError: count(): Argument woocommerce/woocommerce-blocks#12058 ($value) must be of type Countable|array, null given in /public/wp-content/plugins/woocommerce-gutenberg-products-block-11877/src/Patterns/PatternUpdater.php:64Why
Testing Instructions
Please consider any edge cases this change may have, and also other areas of the product this may impact.
/wp-admin/tools.php?page=woocommerce-admin-test-helperand enablecustomize-storefeature flag:Test the CYS experience
Screenshots or screencast
WooCommerce Visibility
Required:
Checklist
Required:
[type]label or a[skip-changelog]label.Conditional:
[skip-changelog]label is not present).Changelog