This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
Fix pattern route performance #11535
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
11 tasks
|
The release ZIP for this PR is accessible via: Script Dependencies ReportThere is no changed script dependency between this branch and trunk. This comment was automatically generated by the TypeScript Errors Report
🎉 🎉 This PR does not introduce new TS errors. |
|
Size Change: 0 B Total Size: 1.54 MB ℹ️ View Unchanged
|
Migrate internal AI routes to WooCommerce Core codebase.Migrate internal AI routes to WooCommerce Core codebase.
woocommerce-blocks/src/StoreApi/RoutesController.php Lines 62 to 71 in 8325b5e 🚀 This comment was generated by the automations bot based on a
|
…o fix/pattern-route-performance WIP WIP
…e/woocommerce-blocks into fix/pattern-route-performance
gigitux
force-pushed
the
fix/pattern-route-performance
branch
from
95aeb81 to
b9a5808
Compare
gigitux
added
type: enhancement
albarin
reviewed
Nov 3, 2023
| } | ||
|
|
||
| /** | ||
| * Get the Patterns response. |
There was a problem hiding this comment.
I think the get_item_response comment is the same in all schemas files.
albarin
reviewed
Nov 3, 2023
| } | ||
|
|
||
| /** | ||
| * Ensure the content and images in patterns are powered by AI. |
There was a problem hiding this comment.
Same here, it's the same comment for a few of the endpoints.
albarin
approved these changes
Nov 3, 2023
gigitux
changed the title
…o fix/pattern-route-performance
…e/woocommerce-blocks into fix/pattern-route-performance
|
Moving to 11.6.0 |
…_products_to_update method for handling the fetch of dummy products to be updated.
…ate method for fetching dummy products to avoid code repetition and add safety checks and handle errors in case certain properties are not available.
|
Great work here @gigitux 🎉 ! Confirmed that with this change, we have a significant boost in performance, well done! I hope you don't mind I pushed a few changes here to address some issues found during testing and also to remove redundancies: On 827bc3c , the On 7c69cef , a change was made to ensure the Product endpoint relies on the newly created On 4a9ff4a a change was made to ensure the On 734e485. The memory increase was also removed and doc blocks updated. I can confirm the feature works, but it would be great if more folks could re-test the PR with the latest changes to ensure everything is working as expected. cc: @albarin @tjcafferkey. Here's the latest zip file for testing: |
|
When I generate a store using the experience I land on the following page:
However, when I click on the homepage templates I get correctly generated templates and patterns as seen below.
Is this a known issue at this point, and thus expected? |
|
I also get inaccurate text, pretty sure this is a known issue with this pattern but raising for confirmation?
|
|
Thanks for the review, @tjcafferkey!
This issue woocommerce/woocommerce#41229 was fixed yesterday and the Core build uploaded here doesn't contain the patch.
Just to confirm, for "inaccurate text" are you referring to the duplicate text? If yes, @albarin fixed it (#11612), but this branch doesn't contain the patch. |
|
Thanks @gigitux I will continue to review the code now. |
tjcafferkey
approved these changes
Nov 7, 2023
|
@gigitux @tjcafferkey FYI: I just noticed that we could occasionally have products with content not updated without increasing the max_execution_time, so I went ahead and re-added it here since it is still required: 31daa33 |
gigitux
added a commit
that referenced
this pull request
Nov 8, 2023
* fix pattern route performance * update namespace * improve middleware * improve ProductSchema * improve error handling * update identifier * fix middleware * update description * use schema to return the response * Break down the generate_content method and create the new fetch_dummy_products_to_update method for handling the fetch of dummy products to be updated. * Ensure the Product endpoint relies on the fetch_dummy_products_to_update method for fetching dummy products to avoid code repetition and add safety checks and handle errors in case certain properties are not available. * Add error handling for the Products endpoint. * Remove memory limit increase and update docblocks. * re-add set_time_limit --------- Co-authored-by: Patricia Hillebrandt <[email protected]>
gigitux
added
the
skip-changelog
gigitux
added a commit
that referenced
this pull request
Nov 8, 2023
* Empty commit for release pull request * Add readme and testing notes * Bump versions to 11.5.1 * Fix Single Product Classic Template block not showing on the front-end (#11455) In WordPress 6.4, it appears that the global `have_posts` is `false` in the context of the full site editing single product template. This breaks the Classic Template block. In this commit, we are creating a custom query using the available id instead of relying on the global query. This might be a temporary workaround as we are waiting to see if that's an issue that core is willing to fix, as it might affect backwards-compatibility for other vendors. (cherry picked from commit d9e8809) * Update testing notes with new zip file * Add protection against wrong params in get_block_template_fallback() (#11690) * Add protection towards wrong params in get_block_template_fallback() * Improve protection * Update WC Blocks 11.5.1 changelog and testing steps with new fix * bump version * [CYS] Fix decoding issue and pattern (#11681) * Fix pattern description * Decode the actual file content, not the filepath * Use wp_post table instead wp_option to store patterns data generated by AI (#11659) * Use wp_post table instead wp_option to store patterns data generated by AI * avoid crash when there isn't any patterns_ai_data post type * restore check * remove unnecessary constant * catch error * pass boolean to return WP_Error * Rename Centered Header Menu with Search pattern (#11637) * Rename Centered Header Menu with Search pattern Since the search bar has been removed from this pattern, this PR renames the pattern title and slug to reflect that change. * Rename file to reflect search removal. Remove `search` from the filename, as this no longer reflects the pattern. * Add missing condition to avoid a php warning when 'plugins' is not set (#11652) * Fix pattern route performance (#11535) * fix pattern route performance * update namespace * improve middleware * improve ProductSchema * improve error handling * update identifier * fix middleware * update description * use schema to return the response * Break down the generate_content method and create the new fetch_dummy_products_to_update method for handling the fetch of dummy products to be updated. * Ensure the Product endpoint relies on the fetch_dummy_products_to_update method for fetching dummy products to avoid code repetition and add safety checks and handle errors in case certain properties are not available. * Add error handling for the Products endpoint. * Remove memory limit increase and update docblocks. * re-add set_time_limit --------- Co-authored-by: Patricia Hillebrandt <[email protected]> * Empty commit for release pull request * add testing instructions * add zip link --------- Co-authored-by: github-actions <[email protected]> Co-authored-by: Lucio Giannotta <[email protected]> Co-authored-by: Albert Juhé Lluveras <[email protected]> Co-authored-by: Luigi <[email protected]> Co-authored-by: Alba Rincón <[email protected]> Co-authored-by: Daniel W. Robert <[email protected]> Co-authored-by: Patricia Hillebrandt <[email protected]>
gigitux
added a commit
that referenced
this pull request
Nov 8, 2023
* Empty commit for release pull request * Add readme and testing notes * Bump versions to 11.5.1 * Fix Single Product Classic Template block not showing on the front-end (#11455) In WordPress 6.4, it appears that the global `have_posts` is `false` in the context of the full site editing single product template. This breaks the Classic Template block. In this commit, we are creating a custom query using the available id instead of relying on the global query. This might be a temporary workaround as we are waiting to see if that's an issue that core is willing to fix, as it might affect backwards-compatibility for other vendors. (cherry picked from commit d9e8809) * Update testing notes with new zip file * Add protection against wrong params in get_block_template_fallback() (#11690) * Add protection towards wrong params in get_block_template_fallback() * Improve protection * Update WC Blocks 11.5.1 changelog and testing steps with new fix * bump version * [CYS] Fix decoding issue and pattern (#11681) * Fix pattern description * Decode the actual file content, not the filepath * Use wp_post table instead wp_option to store patterns data generated by AI (#11659) * Use wp_post table instead wp_option to store patterns data generated by AI * avoid crash when there isn't any patterns_ai_data post type * restore check * remove unnecessary constant * catch error * pass boolean to return WP_Error * Rename Centered Header Menu with Search pattern (#11637) * Rename Centered Header Menu with Search pattern Since the search bar has been removed from this pattern, this PR renames the pattern title and slug to reflect that change. * Rename file to reflect search removal. Remove `search` from the filename, as this no longer reflects the pattern. * Add missing condition to avoid a php warning when 'plugins' is not set (#11652) * Fix pattern route performance (#11535) * fix pattern route performance * update namespace * improve middleware * improve ProductSchema * improve error handling * update identifier * fix middleware * update description * use schema to return the response * Break down the generate_content method and create the new fetch_dummy_products_to_update method for handling the fetch of dummy products to be updated. * Ensure the Product endpoint relies on the fetch_dummy_products_to_update method for fetching dummy products to avoid code repetition and add safety checks and handle errors in case certain properties are not available. * Add error handling for the Products endpoint. * Remove memory limit increase and update docblocks. * re-add set_time_limit --------- Co-authored-by: Patricia Hillebrandt <[email protected]> * Empty commit for release pull request * add testing instructions * add zip link * [CYS] Fix decoding issue and pattern (#11681) * Fix pattern description * Decode the actual file content, not the filepath * bump version * add changelog * add zip link * add link to the readme --------- Co-authored-by: github-actions <[email protected]> Co-authored-by: Lucio Giannotta <[email protected]> Co-authored-by: Albert Juhé Lluveras <[email protected]> Co-authored-by: Luigi <[email protected]> Co-authored-by: Alba Rincón <[email protected]> Co-authored-by: Daniel W. Robert <[email protected]> Co-authored-by: Patricia Hillebrandt <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR linked with woocommerce/woocommerce#41168
What
Fixes #
Why
This PR splits the
/patternsendpoint into different endpoints to allow the client to parallelize the requests. The new endpoints are:/private/ai/images-> generate images and return the client the image URLs./private/ai/products-> generate the payload to pass to /ai/product./private/ai/product-> update a specific product./private/ai/patterns-> generate and save patterns.In the next iteration, we should improve how we handle the errors, but for now, these endpoints are private, so it should not be a big issue.
Testing Instructions
Please consider any edge cases this change may have, and also other areas of the product this may impact.
/wp-admin/tools.php?page=woocommerce-admin-test-helperand enablecustomize-storefeature flag:Test the AI-managed images
Screenshots or screencast
WooCommerce Visibility
Required:
Checklist
Required:
[type]label or a[skip-changelog]label.Conditional:
[skip-changelog]label is not present).Changelog