Product list selection #7971

atorresveiga · 2022-12-01T01:01:22Z

Closes: #7929
Closes: #7930

Why

To be able able to bulk update products, first, the merchant needs to select the products he wants to update.

Description

This task is about enabling a selectable state of the products list view. It allows product selection by using the SelectionTracker, part of androidx.recyclerview.selection, an addon library providing support for item selection.

Testing instructions

TC1

Open the products list screen
Tap on the multi-select menu item
Check that the view enters on selection mode
Tap on the products and check that the selection/deselection works as expected
Check that the selection count works as expected

TC2

Open the products list screen
Long press a product and check that the view enters on selection mode
Complete Steps 4 and 5 of TC1

TC3

Open the products list screen
Tap on the multi-select menu item
Tap on the more menu (3 dots)
Tap on Select All
Check that all loaded products are selected

TC4

Open the products list screen
Tap on Search
Type a valid search query
Long press a product to enter selection mode
Tap on <- to exit the selection mode
Tap on <- to exit the search
Check that the app doesn't crash.
Check this comment

Images/gif

selection.mp4

I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

wpmobilebot · 2022-12-01T01:19:49Z

You can test the changes on this Pull Request by downloading an installable build, or scanning this QR code:

…ist-selection # Conflicts: # WooCommerce/src/main/kotlin/com/woocommerce/android/ui/products/ProductListFragment.kt

codecov-commenter · 2022-12-02T01:54:12Z

Codecov Report

Base: 41.79% // Head: 41.85% // Increases project coverage by +0.06% 🎉

Coverage data is based on head (7987e34) compared to base (990af07).
Patch coverage: 50.87% of modified lines in pull request are covered.

Additional details and impacted files

@@             Coverage Diff              @@
##              trunk    #7971      +/-   ##
============================================
+ Coverage     41.79%   41.85%   +0.06%     
- Complexity     3477     3486       +9     
============================================
  Files           688      689       +1     
  Lines         37317    37463     +146     
  Branches       4826     4834       +8     
============================================
+ Hits          15596    15682      +86     
- Misses        20310    20367      +57     
- Partials       1411     1414       +3

Impacted Files	Coverage Δ
.../woocommerce/android/analytics/AnalyticsTracker.kt	`20.76% <ø> (ø)`
...tlin/com/woocommerce/android/extensions/ViewExt.kt	`0.00% <0.00%> (ø)`
...d/ui/products/MutableMultipleSelectionPredicate.kt	`0.00% <0.00%> (ø)`
...merce/android/ui/products/ProductListRepository.kt	`8.63% <0.00%> (-1.13%)`	⬇️
...oid/ui/products/ProductSelectionItemKeyProvider.kt	`0.00% <0.00%> (ø)`
...e/android/ui/products/ProductSortAndFiltersCard.kt	`0.00% <0.00%> (ø)`
...oid/ui/products/SelectableProductListItemLookup.kt	`0.00% <0.00%> (ø)`
...mmerce/android/ui/products/ProductListViewModel.kt	`56.11% <74.75%> (+7.38%)`	⬆️
...om/woocommerce/android/analytics/AnalyticsEvent.kt	`100.00% <100.00%> (ø)`
...m/woocommerce/android/viewmodel/ScopedViewModel.kt	`100.00% <100.00%> (ø)`

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

atorresveiga · 2022-12-02T18:34:01Z

P2 about the changes implemented here that diverges from the task's design

…ist-selection

peril-woocommerce · 2022-12-06T00:31:40Z

	Warnings
⚠️	PR is not assigned to a milestone.
⚠️	PR has more than 300 lines of code changing. Consider splitting into smaller PRs if possible.

Generated by 🚫 dangerJS

…agment Fix/list multi-select top fragment

wzieba

Thank you, great work @atorresveiga ! Leaving some comments

wzieba · 2022-12-06T14:21:10Z

WooCommerce/src/main/kotlin/com/woocommerce/android/ui/products/ProductListFragment.kt

+                    val selectionCount = tracker?.selection?.size() ?: 0
+                    if (selectionCount > 0 && actionMode == null) {
+                        viewModel.enterSelectionMode()
+                        actionMode = (requireActivity() as AppCompatActivity)
+                            .startSupportActionMode(this@ProductListFragment)
+                    }
+                    when (selectionCount) {
+                        0 -> {
+                            viewModel.exitSelectionMode()
+                            actionMode?.finish()
+                        }
+                        else -> {
+                            actionMode?.title = StringUtils.getQuantityString(
+                                context = requireContext(),
+                                quantity = selectionCount,
+                                default = R.string.product_selection_count,
+                                one = R.string.product_selection_count_single
+                            )
+                        }
+                    }


⚙️ Can we move this logic to ViewModel? We should only pass information about selection change and a number of selected items to VM and then orchestrate changes from ViewModel.

Suggested change

val selectionCount = tracker?.selection?.size() ?: 0

if (selectionCount > 0 && actionMode == null) {

viewModel.enterSelectionMode()

actionMode = (requireActivity() as AppCompatActivity)

.startSupportActionMode(this@ProductListFragment)

}

when (selectionCount) {

0 -> {

viewModel.exitSelectionMode()

actionMode?.finish()

}

else -> {

actionMode?.title = StringUtils.getQuantityString(

context = requireContext(),

quantity = selectionCount,

default = R.string.product_selection_count,

one = R.string.product_selection_count_single

)

}

}

val selectionCount = tracker?.selection?.size() ?: 0

viewModel.onSelectionChanged(selectionCount)

wzieba · 2022-12-06T14:22:47Z

WooCommerce/src/main/kotlin/com/woocommerce/android/ui/products/ProductListViewModel.kt

@@ -197,6 +199,7 @@ class ProductListViewModel @Inject constructor(
    }

    fun onLoadMoreRequested() {
+        if (isSelecting()) return


❓ Would pagination in a selectable state break something? If not, maybe we could allow users to load more products even if they are in selectable state?

Yes, it breaks the selection state. I'll take a closer look to see if it is possible to add pagination to the selection

I think it's generally a low priority. I think we can proceed with this feature with the behavior you proposed in this PR and then improve it later.

I found out what the problem was, so we have list selection with pagination now 😁

wzieba · 2022-12-06T14:23:59Z

WooCommerce/src/main/kotlin/com/woocommerce/android/ui/products/ProductListViewModel.kt

+    sealed class ProductListState : Parcelable {
+        @Parcelize
+        object Selecting : ProductListState()
+
+        @Parcelize
+        object Browsing : ProductListState()


NP: as those classes have no state, maybe we could consider using enum to reduce code

wzieba · 2022-12-06T14:25:12Z

WooCommerce/src/main/kotlin/com/woocommerce/android/ui/products/ProductListFragment.kt

+            ProductListViewModel.ProductListState.Browsing -> {
+                onListSelectionActiveChanged(false)


⚙️ We should also clear selection when entering browsing state. Otherwise, the state is inconsistent.

Suggested change

ProductListViewModel.ProductListState.Browsing -> {

onListSelectionActiveChanged(false)

ProductListViewModel.ProductListState.Browsing -> {

tracker?.clearSelection()

onListSelectionActiveChanged(false)

…ulk-product-status-update # Conflicts: # WooCommerce/src/main/kotlin/com/woocommerce/android/ui/products/ProductListViewModel.kt

…add-bulk-products-update-tracks # Conflicts: # WooCommerce/src/main/kotlin/com/woocommerce/android/ui/products/ProductListViewModel.kt # WooCommerce/src/test/kotlin/com/woocommerce/android/ui/products/ProductListViewModelTest.kt

ThomazFB · 2022-12-09T18:42:34Z

Thanks for this implementation @atorresveiga! The selection code and strategy look great, but I'm noticing some weird behavior with the selection itself. At first, I managed to use it and test all scenarios without issues, but now, when I try to select a product during the selection mode, the Product Details is called, and the selection enters a weird state. Here are some captures showing how this is happening:

screencapture-1670611067907.mp4

It's possible to verify that when I come back from the Product Details view, the selection state gets inconsistent, displaying 25 selected products, but the list is not reflecting that.

…s-update-tracks feat: add tracks events for product bulk update

ThomazFB

Considering our talk on Slack and how hard it's to reproduce the issue mentioned above in a physical device. I'll approving this PR as the feature overall looks to be working nicely!

…tus-update feat: bulk update products status

…ce-update feat: update prices of selected products

…m/woocommerce/woocommerce-android into issue/7929-product-list-selection

ThomazFB · 2022-12-12T16:52:30Z

Thanks for moving forward with the fix @atorresveiga! 🙇 It's working perfectly! I didn't manage to reproduce the issue again in any way! Amazing work!

Alejo added 2 commits November 30, 2022 18:50

add product selection menu

1bf36e0

products selection with SelectionTracker

b6ed2f3

atorresveiga added the feature: product list Related to the product list. label Dec 1, 2022

atorresveiga requested a review from wzieba December 1, 2022 01:01

atorresveiga changed the title ~~Issue/7929 product list selection~~ Product list selection Dec 1, 2022

Alejo added 7 commits December 1, 2022 11:46

revert selection hotspot

0f0406f

update list item lookups

66ce41a

fix space warning

37fa0fa

fix configuration change

fc3665e

refactor product selection

b3d18f5

Merge remote-tracking branch 'origin/trunk' into issue/7929-product-l…

59b59fd

…ist-selection # Conflicts: # WooCommerce/src/main/kotlin/com/woocommerce/android/ui/products/ProductListFragment.kt

toolbar style

7da6f66

atorresveiga added the needs: design Requires design input/work from a designer. label Dec 2, 2022

fix menu style

69a36fb

Alejo added 3 commits December 5, 2022 17:12

add mutable multi selection predicate

2a742da

delay multi selection

f52a0a5

Merge remote-tracking branch 'origin/trunk' into issue/7929-product-l…

78935ba

…ist-selection

Merge pull request #7990 from woocommerce/fix/list-multiselect-top-fr…

025e609

…agment Fix/list multi-select top fragment

atorresveiga added the status: do not merge Dependent on another PR, ready for review but not ready for merge. label Dec 6, 2022

atorresveiga marked this pull request as ready for review December 6, 2022 14:18

wzieba reviewed Dec 6, 2022

View reviewed changes

feat: update prices of selected products

5dc10c9

atorresveiga removed the status: do not merge Dependent on another PR, ready for review but not ready for merge. label Dec 6, 2022

wzieba added 3 commits December 7, 2022 10:21

style: remove boilerplate from xml layout

cd7c159

feat: add success/error snackbar messages

8c25ccb

refactor: orchestrate showing dialog via VM

b75acf1

Alejo added 3 commits December 8, 2022 17:19

keep toolbar collapsed while searching

df2bb3a

ignore field clean up calls

8589e11

fix detekt spacing warning

53d415f

ThomazFB self-assigned this Dec 9, 2022

Alejo added 11 commits December 9, 2022 07:43

show refreshing state while updating products

bc3de29

trigger events with delay

bcea90d

use collapse/expand default constant

6e360e0

fix detekt warnings

74cfef8

refactor to use List instead of Collection

dabcaaa

unit test bulk update price

6ad0d35

fix indentation

14f0b68

Merge branch 'issue/7933-bulk-product-price-update' into issue/7932-b…

b32af47

…ulk-product-status-update # Conflicts: # WooCommerce/src/main/kotlin/com/woocommerce/android/ui/products/ProductListViewModel.kt

refactor improving readability

af8e85e

add unit tests to bulk update products' statuses

479c245

Merge pull request #8005 from woocommerce/issue/8004-add-bulk-product…

893e70c

…s-update-tracks feat: add tracks events for product bulk update

ThomazFB approved these changes Dec 9, 2022

View reviewed changes

Alejo and others added 4 commits December 9, 2022 15:30

prevent detail navigation

7f3537e

Merge pull request #8000 from woocommerce/issue/7932-bulk-product-sta…

84268d1

…tus-update feat: bulk update products status

Merge pull request #7997 from woocommerce/issue/7933-bulk-product-pri…

e01a491

…ce-update feat: update prices of selected products

Merge branch 'issue/7929-product-list-selection' of https://github.co…

7987e34

…m/woocommerce/woocommerce-android into issue/7929-product-list-selection

atorresveiga mentioned this pull request Dec 10, 2022

Call to the API only when needed wordpress-mobile/WordPress-FluxC-Android#2590

Merged

atorresveiga added this to the 11.7 milestone Dec 12, 2022

ThomazFB merged commit 4c4720e into trunk Dec 12, 2022

ThomazFB deleted the issue/7929-product-list-selection branch December 12, 2022 16:52

atorresveiga mentioned this pull request Jan 10, 2023

Product selection with Talkback enabled #8160

Merged

1 task

This was referenced Dec 16, 2024

[Bulk Update Orders] Enable multiple selection in Order List: Part I #13131

Merged

[Bulk Update Orders] Enable multiple selection in Order List: Part II #13151

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Product list selection #7971

Product list selection #7971

atorresveiga commented Dec 1, 2022 •

edited

Loading

wpmobilebot commented Dec 1, 2022 •

edited

Loading

codecov-commenter commented Dec 2, 2022 •

edited

Loading

atorresveiga commented Dec 2, 2022 •

edited

Loading

peril-woocommerce bot commented Dec 6, 2022 •

edited

Loading

wzieba left a comment

wzieba Dec 6, 2022

wzieba Dec 6, 2022

atorresveiga Dec 7, 2022

wzieba Dec 7, 2022

atorresveiga Dec 7, 2022

wzieba Dec 6, 2022

wzieba Dec 6, 2022

ThomazFB commented Dec 9, 2022

ThomazFB left a comment

ThomazFB commented Dec 12, 2022

		ProductListViewModel.ProductListState.Browsing -> {
		onListSelectionActiveChanged(false)

Product list selection #7971

Product list selection #7971

Conversation

atorresveiga commented Dec 1, 2022 • edited Loading

Why

Description

Testing instructions

Images/gif

wpmobilebot commented Dec 1, 2022 • edited Loading

codecov-commenter commented Dec 2, 2022 • edited Loading

Codecov Report

atorresveiga commented Dec 2, 2022 • edited Loading

peril-woocommerce bot commented Dec 6, 2022 • edited Loading

wzieba left a comment

Choose a reason for hiding this comment

wzieba Dec 6, 2022

Choose a reason for hiding this comment

wzieba Dec 6, 2022

Choose a reason for hiding this comment

atorresveiga Dec 7, 2022

Choose a reason for hiding this comment

wzieba Dec 7, 2022

Choose a reason for hiding this comment

atorresveiga Dec 7, 2022

Choose a reason for hiding this comment

wzieba Dec 6, 2022

Choose a reason for hiding this comment

wzieba Dec 6, 2022

Choose a reason for hiding this comment

ThomazFB commented Dec 9, 2022

ThomazFB left a comment

Choose a reason for hiding this comment

ThomazFB commented Dec 12, 2022

atorresveiga commented Dec 1, 2022 •

edited

Loading

wpmobilebot commented Dec 1, 2022 •

edited

Loading

codecov-commenter commented Dec 2, 2022 •

edited

Loading

atorresveiga commented Dec 2, 2022 •

edited

Loading

peril-woocommerce bot commented Dec 6, 2022 •

edited

Loading