Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Dagger to 2.42 #6846

Merged
merged 1 commit into from
Jul 4, 2022
Merged

Update Dagger to 2.42 #6846

merged 1 commit into from
Jul 4, 2022

Conversation

oguzkocer
Copy link
Contributor

@oguzkocer oguzkocer commented Jul 1, 2022 •
edited
Loading

Description

AGP 7.2.1 update results in a crash during lint due to a bug in Dagger which is addressed in 2.42. This PR updates Dagger to 2.42 and targets the AGP update branch, so they can be shipped together.

Testing instructions

We'll test these changes together with the AGP 7.2.1 update.

Images/gif

  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@oguzkocer oguzkocer added this to the 9.6 milestone Jul 1, 2022
@peril-woocommerce
Copy link

You can trigger optional UI/connected tests for these changes by visiting CircleCI here.

@wpmobilebot
Copy link
Collaborator

Found 1 violations:

The PR caused the following dependency changes:

expand 

 +--- org.wordpress:fluxc:1.45.1
-|    \--- com.google.dagger:dagger:2.29.1 -> 2.41
+|    \--- com.google.dagger:dagger:2.29.1 -> 2.42
 +--- org.wordpress.fluxc.plugins:woocommerce:1.45.1
-|    \--- com.google.dagger:dagger:2.29.1 -> 2.41 (*)
+|    \--- com.google.dagger:dagger:2.29.1 -> 2.42 (*)
 +--- org.wordpress:login:0.13.0
-|    +--- com.google.dagger:dagger:2.33 -> 2.41 (*)
+|    +--- com.google.dagger:dagger:2.33 -> 2.42 (*)
-|    \--- com.google.dagger:dagger-android-support:2.33 -> 2.40.5
-|         +--- com.google.dagger:dagger:2.40.5 -> 2.41 (*)
-|         +--- com.google.dagger:dagger-android:2.40.5
-|         |    +--- com.google.dagger:dagger:2.40.5 -> 2.41 (*)
-|         |    +--- com.google.dagger:dagger-lint-aar:2.40.5
-|         |    +--- androidx.annotation:annotation:1.2.0 -> 1.3.0
-|         |    \--- javax.inject:javax.inject:1
-|         +--- com.google.dagger:dagger-lint-aar:2.40.5
-|         +--- androidx.activity:activity:1.3.1 -> 1.4.0 (*)
-|         +--- androidx.annotation:annotation:1.2.0 -> 1.3.0
-|         +--- androidx.appcompat:appcompat:1.3.1 -> 1.4.1 (*)
-|         +--- androidx.fragment:fragment:1.3.6 -> 1.4.1 (*)
-|         +--- androidx.lifecycle:lifecycle-common:2.3.1 -> 2.4.1 (*)
-|         +--- androidx.lifecycle:lifecycle-viewmodel:2.3.1 -> 2.4.1 (*)
-|         +--- androidx.lifecycle:lifecycle-viewmodel-savedstate:2.3.1 -> 2.4.1 (*)
-|         \--- javax.inject:javax.inject:1
+|    \--- com.google.dagger:dagger-android-support:2.33 -> 2.42
+|         +--- com.google.dagger:dagger:2.42 (*)
+|         +--- com.google.dagger:dagger-android:2.42
+|         |    +--- com.google.dagger:dagger:2.42 (*)
+|         |    +--- com.google.dagger:dagger-lint-aar:2.42
+|         |    +--- androidx.annotation:annotation:1.2.0 -> 1.3.0
+|         |    \--- javax.inject:javax.inject:1
+|         +--- com.google.dagger:dagger-lint-aar:2.42
+|         +--- androidx.activity:activity:1.3.1 -> 1.4.0 (*)
+|         +--- androidx.annotation:annotation:1.2.0 -> 1.3.0
+|         +--- androidx.appcompat:appcompat:1.3.1 -> 1.4.1 (*)
+|         +--- androidx.fragment:fragment:1.3.6 -> 1.4.1 (*)
+|         +--- androidx.lifecycle:lifecycle-common:2.3.1 -> 2.4.1 (*)
+|         +--- androidx.lifecycle:lifecycle-viewmodel:2.3.1 -> 2.4.1 (*)
+|         +--- androidx.lifecycle:lifecycle-viewmodel-savedstate:2.3.1 -> 2.4.1 (*)
+|         \--- javax.inject:javax.inject:1
 +--- project :libs:cardreader
 |    \--- com.stripe:stripeterminal:2.10.0
 |         \--- com.stripe:stripeterminal-core:2.10.0
 |              +--- com.stripe:stripeterminal-internal-common:2.10.0
-|              |    \--- com.google.dagger:dagger:2.41 (*)
+|              |    \--- com.google.dagger:dagger:2.41 -> 2.42 (*)
-|              \--- com.google.dagger:dagger:2.41 (*)
+|              \--- com.google.dagger:dagger:2.41 -> 2.42 (*)
-+--- com.google.dagger:hilt-android:2.40.5
-|    +--- com.google.dagger:dagger:2.40.5 -> 2.41 (*)
-|    +--- com.google.dagger:dagger-lint-aar:2.40.5
-|    +--- com.google.dagger:hilt-core:2.40.5
-|    |    +--- com.google.dagger:dagger:2.40.5 -> 2.41 (*)
-|    |    +--- com.google.code.findbugs:jsr305:3.0.2
-|    |    \--- javax.inject:javax.inject:1
-|    +--- com.google.code.findbugs:jsr305:3.0.2
-|    +--- androidx.activity:activity:1.3.1 -> 1.4.0 (*)
-|    +--- androidx.annotation:annotation:1.2.0 -> 1.3.0
-|    +--- androidx.fragment:fragment:1.3.6 -> 1.4.1 (*)
-|    +--- androidx.lifecycle:lifecycle-common:2.3.1 -> 2.4.1 (*)
-|    +--- androidx.lifecycle:lifecycle-viewmodel:2.3.1 -> 2.4.1 (*)
-|    +--- androidx.lifecycle:lifecycle-viewmodel-savedstate:2.3.1 -> 2.4.1 (*)
-|    +--- androidx.savedstate:savedstate:1.1.0 (*)
-|    \--- javax.inject:javax.inject:1
++--- com.google.dagger:hilt-android:2.42
+|    +--- com.google.dagger:dagger:2.42 (*)
+|    +--- com.google.dagger:dagger-lint-aar:2.42
+|    +--- com.google.dagger:hilt-core:2.42
+|    |    +--- com.google.dagger:dagger:2.42 (*)
+|    |    +--- com.google.code.findbugs:jsr305:3.0.2
+|    |    \--- javax.inject:javax.inject:1
+|    +--- com.google.code.findbugs:jsr305:3.0.2
+|    +--- androidx.activity:activity:1.3.1 -> 1.4.0 (*)
+|    +--- androidx.annotation:annotation:1.2.0 -> 1.3.0
+|    +--- androidx.fragment:fragment:1.3.6 -> 1.4.1 (*)
+|    +--- androidx.lifecycle:lifecycle-common:2.3.1 -> 2.4.1 (*)
+|    +--- androidx.lifecycle:lifecycle-viewmodel:2.3.1 -> 2.4.1 (*)
+|    +--- androidx.lifecycle:lifecycle-viewmodel-savedstate:2.3.1 -> 2.4.1 (*)
+|    +--- androidx.savedstate:savedstate:1.1.0 (*)
+|    +--- javax.inject:javax.inject:1
+|    \--- org.jetbrains.kotlin:kotlin-stdlib:1.6.10 (*)
 +--- androidx.hilt:hilt-navigation-fragment:1.0.0
 |    \--- androidx.hilt:hilt-navigation:1.0.0
-|         \--- com.google.dagger:hilt-android:2.35 -> 2.40.5 (*)
+|         \--- com.google.dagger:hilt-android:2.35 -> 2.42 (*)
-+--- com.google.dagger:dagger-android-support:2.40.5 (*)
++--- com.google.dagger:dagger-android-support:2.42 (*)
 +--- com.zendesk:support:5.0.8
 |    +--- com.zendesk:support-providers:5.0.8
 |    |    +--- com.zendesk:core:4.0.6
-|    |    |    \--- com.google.dagger:dagger:2.40 -> 2.41 (*)
+|    |    |    \--- com.google.dagger:dagger:2.40 -> 2.42 (*)
 |    |    +--- com.zendesk:guide-providers:1.0.7
-|    |    |    \--- com.google.dagger:dagger:2.40 -> 2.41 (*)
+|    |    |    \--- com.google.dagger:dagger:2.40 -> 2.42 (*)
-|    |    \--- com.google.dagger:dagger:2.40 -> 2.41 (*)
+|    |    \--- com.google.dagger:dagger:2.40 -> 2.42 (*)
 |    +--- com.zendesk:guide:1.0.7
 |    |    +--- com.zendesk:messaging:5.2.3
-|    |    |    \--- com.google.dagger:dagger:2.40 -> 2.41 (*)
+|    |    |    \--- com.google.dagger:dagger:2.40 -> 2.42 (*)
-|    |    \--- com.google.dagger:dagger-android:2.40 -> 2.40.5 (*)
+|    |    \--- com.google.dagger:dagger-android:2.40 -> 2.42 (*)
-|    \--- com.google.dagger:dagger-android:2.40 -> 2.40.5 (*)
+|    \--- com.google.dagger:dagger-android:2.40 -> 2.42 (*)
 +--- org.wordpress:mediapicker:trunk-d0db2634cf27511bec3ef9b837f9cfe27c5ab601
-|    +--- com.google.dagger:hilt-android:2.40.5 (*)
+|    +--- com.google.dagger:hilt-android:2.40.5 -> 2.42 (*)
 |    \--- com.google.dagger:hilt-android-compiler:2.40.5
-|         +--- com.google.dagger:dagger:2.40.5 -> 2.41 (*)
+|         +--- com.google.dagger:dagger:2.40.5 -> 2.42 (*)
 |         \--- com.google.dagger:dagger-compiler:2.40.5
-|              +--- com.google.dagger:dagger:2.40.5 -> 2.41 (*)
+|              +--- com.google.dagger:dagger:2.40.5 -> 2.42 (*)
 |              +--- com.google.dagger:dagger-producers:2.40.5
-|              |    \--- com.google.dagger:dagger:2.40.5 -> 2.41 (*)
+|              |    \--- com.google.dagger:dagger:2.40.5 -> 2.42 (*)
 |              \--- com.google.dagger:dagger-spi:2.40.5
-|                   \--- com.google.dagger:dagger:2.40.5 -> 2.41 (*)
+|                   \--- com.google.dagger:dagger:2.40.5 -> 2.42 (*)
 +--- org.wordpress.mediapicker:source-device:trunk-d0db2634cf27511bec3ef9b837f9cfe27c5ab601
-|    \--- com.google.dagger:hilt-android:2.40.5 (*)
+|    \--- com.google.dagger:hilt-android:2.40.5 -> 2.42 (*)
 \--- org.wordpress.mediapicker:source-wordpress:trunk-d0db2634cf27511bec3ef9b837f9cfe27c5ab601
-     \--- com.google.dagger:hilt-android:2.40.5 (*)
+     \--- com.google.dagger:hilt-android:2.40.5 -> 2.42 (*)

Please review and act accordingly

@wpmobilebot
Copy link
Collaborator

You can test the changes on this Pull Request by downloading an installable build, or scanning this QR code:

@oguzkocer oguzkocer marked this pull request as ready for review July 1, 2022 14:29
@oguzkocer oguzkocer requested a review from ParaskP7 July 1, 2022 14:29
@ParaskP7 ParaskP7 self-assigned this Jul 4, 2022
ParaskP7
ParaskP7 approved these changes Jul 4, 2022
View reviewed changes
Copy link
Contributor

@ParaskP7 ParaskP7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 💯

PS: I also quickly smoked tested the WooCommerce app and everything looks/works as expected! 👍

@oguzkocer oguzkocer merged commit 968a1bd into upgrade-gradle-to-7.4.2-agp-to-7.2.1 Jul 4, 2022
@oguzkocer oguzkocer deleted the update-dagger-to-2.42 branch July 4, 2022 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ParaskP7 ParaskP7 ParaskP7 approved these changes

Assignees

@ParaskP7 ParaskP7

Labels
dependency update
Projects
None yet
Milestone
9.6
Development

Successfully merging this pull request may close these issues.
3 participants
@oguzkocer @wpmobilebot @ParaskP7