Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue/13495 migrate to use modebottomsheet material3 #13506

Draft
wants to merge 2 commits into
base: trunk
Choose a base branch
from

Conversation

JorgeMucientes
Copy link
Contributor

Closes: #13495

Description

As part of fixing the linked issue this PR migrates existing usages of WCModalBottomSheetLayout to material 3 ModalBottomSheet. This simplifies the implementation of bottomsheets in compose and removes the need of workarounds such the one added to ModalBottomSheetLayoutWithStatusBarWorkaround that causes the issue shown in #13495

Testing information

Review the usage of all compose bottom sheets in the app in the light and dark mode

The tests that have been performed

Images/gif

  • I have considered if this change warrants release notes and have added them to RELEASE-NOTES.txt if necessary. Use the "[Internal]" label for non-user-facing changes.

Reviewer (or Author, in the case of optional code reviews):

Please make sure these conditions are met before approving the PR, or request changes if the PR needs improvement:

  • The PR is small and has a clear, single focus, or a valid explanation is provided in the description. If needed, please request to split it into smaller PRs.
  • Ensure Adequate Unit Test Coverage: The changes are reasonably covered by unit tests or an explanation is provided in the PR description.
  • Manual Testing: The author listed all the tests they ran, including smoke tests when needed (e.g., for refactorings). The reviewer confirmed that the PR works as expected on big (tablet) and small (phone) in case of UI changes, and no regressions are added.

@JorgeMucientes JorgeMucientes added the type: bug A confirmed bug. label Feb 7, 2025
@dangermattic
Copy link
Collaborator

1 Message
📖 This PR is still a Draft: some checks will be skipped.

Generated by 🚫 Danger

@wpmobilebot
Copy link
Collaborator

Project dependencies changes

The following changes in project dependencies were detected (configuration vanillaReleaseRuntimeClasspath):

list

tree
+\--- androidx.compose.material3:material3-android -> 1.3.0 (*)

@wpmobilebot
Copy link
Collaborator

📲 You can test the changes from this Pull Request in WooCommerce-Wear Android by scanning the QR code below to install the corresponding build.
App Name WooCommerce-Wear Android
Platform⌚️ Wear OS
FlavorJalapeno
Build TypeDebug
Commit81a5233
Direct Downloadwoocommerce-wear-prototype-build-pr13506-81a5233.apk

@wpmobilebot
Copy link
Collaborator

📲 You can test the changes from this Pull Request in WooCommerce Android by scanning the QR code below to install the corresponding build.

App Name WooCommerce Android
Platform📱 Mobile
FlavorJalapeno
Build TypeDebug
Commit81a5233
Direct Downloadwoocommerce-prototype-build-pr13506-81a5233.apk

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug A confirmed bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Edge to edge issue on Blaze list screen
3 participants