Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Woo POS][Design system] Move text styles in the code #13502

Draft
wants to merge 4 commits into
base: 13470-woo-posdesign-system-move-colors-from-ds-to-the-code
Choose a base branch
from

Conversation

kidinov
Copy link
Contributor

@kidinov kidinov commented Feb 7, 2025

Closes: #13471

Description

Steps to reproduce

Testing information

The tests that have been performed

Images/gif

  • I have considered if this change warrants release notes and have added them to RELEASE-NOTES.txt if necessary. Use the "[Internal]" label for non-user-facing changes.

Reviewer (or Author, in the case of optional code reviews):

Please make sure these conditions are met before approving the PR, or request changes if the PR needs improvement:

  • The PR is small and has a clear, single focus, or a valid explanation is provided in the description. If needed, please request to split it into smaller PRs.
  • Ensure Adequate Unit Test Coverage: The changes are reasonably covered by unit tests or an explanation is provided in the PR description.
  • Manual Testing: The author listed all the tests they ran, including smoke tests when needed (e.g., for refactorings). The reviewer confirmed that the PR works as expected on big (tablet) and small (phone) in case of UI changes, and no regressions are added.

@kidinov kidinov marked this pull request as draft February 7, 2025 15:33
@dangermattic
Copy link
Collaborator

1 Message
📖 This PR is still a Draft: some checks will be skipped.

Generated by 🚫 Danger

@wpmobilebot
Copy link
Collaborator

📲 You can test the changes from this Pull Request in WooCommerce-Wear Android by scanning the QR code below to install the corresponding build.
App Name WooCommerce-Wear Android
Platform⌚️ Wear OS
FlavorJalapeno
Build TypeDebug
Commit8275b6c
Direct Downloadwoocommerce-wear-prototype-build-pr13502-8275b6c.apk

@wpmobilebot
Copy link
Collaborator

📲 You can test the changes from this Pull Request in WooCommerce Android by scanning the QR code below to install the corresponding build.

App Name WooCommerce Android
Platform📱 Mobile
FlavorJalapeno
Build TypeDebug
Commit8275b6c
Direct Downloadwoocommerce-prototype-build-pr13502-8275b6c.apk

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0% with 184 lines in your changes missing coverage. Please review.

Project coverage is 37.83%. Comparing base (8bfeec2) to head (8275b6c).

Files with missing lines Patch % Lines
...oid/ui/woopos/common/composeui/WooPosTypography.kt 0.00% 184 Missing ⚠️
Additional details and impacted files
@@                                       Coverage Diff                                        @@
##             13470-woo-posdesign-system-move-colors-from-ds-to-the-code   #13502      +/-   ##
================================================================================================
- Coverage                                                         37.89%   37.83%   -0.07%     
  Complexity                                                         8957     8957              
================================================================================================
  Files                                                              2050     2051       +1     
  Lines                                                            112082   112266     +184     
  Branches                                                          14172    14180       +8     
================================================================================================
  Hits                                                              42477    42477              
- Misses                                                            65726    65910     +184     
  Partials                                                           3879     3879              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants