Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[In Person Payments] Transactions below minimal amount, error message is missing #13415

Draft
wants to merge 5 commits into
base: trunk
Choose a base branch
from

Conversation

kidinov
Copy link
Contributor

@kidinov kidinov commented Jan 29, 2025

Closes: #13110

Description

The PR implements the changes brought by WooPayments - now we have the data in the error response when the amount is too small and we can use this data to display correct error message to the users

Automattic/woocommerce-payments#10112

Steps to reproduce

Testing information

The tests that have been performed

Images/gif

  • I have considered if this change warrants release notes and have added them to RELEASE-NOTES.txt if necessary. Use the "[Internal]" label for non-user-facing changes.

Reviewer (or Author, in the case of optional code reviews):

Please make sure these conditions are met before approving the PR, or request changes if the PR needs improvement:

  • The PR is small and has a clear, single focus, or a valid explanation is provided in the description. If needed, please request to split it into smaller PRs.
  • Ensure Adequate Unit Test Coverage: The changes are reasonably covered by unit tests or an explanation is provided in the PR description.
  • Manual Testing: The author listed all the tests they ran, including smoke tests when needed (e.g., for refactorings). The reviewer confirmed that the PR works as expected on big (tablet) and small (phone) in case of UI changes, and no regressions are added.

@kidinov kidinov linked an issue Jan 29, 2025 that may be closed by this pull request
2 tasks
@kidinov kidinov added this to the 21.6 milestone Jan 29, 2025
@kidinov kidinov added the feature: mobile payments Related to mobile payments / card present payments / Woo Payments. label Jan 29, 2025
@kidinov kidinov modified the milestones: 21.6, 21.7 Jan 29, 2025
@wpmobilebot
Copy link
Collaborator

wpmobilebot commented Jan 29, 2025

📲 You can test the changes from this Pull Request in WooCommerce-Wear Android by scanning the QR code below to install the corresponding build.
App Name WooCommerce-Wear Android
Platform⌚️ Wear OS
FlavorJalapeno
Build TypeDebug
Commit01b5cfd
Direct Downloadwoocommerce-wear-prototype-build-pr13415-01b5cfd.apk

@kidinov kidinov marked this pull request as draft January 29, 2025 14:38
@wpmobilebot wpmobilebot modified the milestones: 21.7, 21.8 Feb 7, 2025
@wpmobilebot
Copy link
Collaborator

Version 21.7 has now entered code-freeze, so the milestone of this PR has been updated to 21.8.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature: mobile payments Related to mobile payments / card present payments / Woo Payments.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[IPP] Transactions below minimal amount error message missing
2 participants