Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[POS] Simultaneous cash and card payment handling #13277

Draft
wants to merge 3 commits into
base: trunk
Choose a base branch
from

Conversation

samiuelson
Copy link
Collaborator

@samiuelson samiuelson commented Jan 9, 2025

Closes: #13278 13278

Description

This PR adds improvements to the cash payment collection flow:

  1. When "Mark payment as complete" is tapped in the Cash payment screen, the card reader payment intent is canceled.
  2. If the card payment is initiated, the Cash payment screen should be interrupted/closed automatically, showing the card payment processing state.

Steps to reproduce

  1. Open POS (menu more > Point of Sale)
  2. Create order and make sure reader is connected
  3. Click "Cash payment"

Testing information

The tests that have been performed

Images/gif

  1. Payment intent gets canceled when order marked as paid with cash
Screen_recording_20250109_173942.mp4
  1. Cash payment is closed when card is tapped to the reader
Screen_recording_20250109_173912.mp4
  • I have considered if this change warrants release notes and have added them to RELEASE-NOTES.txt if necessary. Use the "[Internal]" label for non-user-facing changes.

Reviewer (or Author, in the case of optional code reviews):

Please make sure these conditions are met before approving the PR, or request changes if the PR needs improvement:

  • The PR is small and has a clear, single focus, or a valid explanation is provided in the description. If needed, please request to split it into smaller PRs.
  • Ensure Adequate Unit Test Coverage: The changes are reasonably covered by unit tests or an explanation is provided in the PR description.
  • Manual Testing: The author listed all the tests they ran, including smoke tests when needed (e.g., for refactorings). The reviewer confirmed that the PR works as expected on big (tablet) and small (phone) in case of UI changes, and no regressions are added.

@dangermattic
Copy link
Collaborator

1 Message
📖 This PR is still a Draft: some checks will be skipped.

Generated by 🚫 Danger

@wpmobilebot
Copy link
Collaborator

wpmobilebot commented Jan 9, 2025

📲 You can test the changes from this Pull Request in WooCommerce-Wear Android by scanning the QR code below to install the corresponding build.
App Name WooCommerce-Wear Android
Platform⌚️ Wear OS
FlavorJalapeno
Build TypeDebug
Commit4a506d8
Direct Downloadwoocommerce-wear-prototype-build-pr13277-4a506d8.apk

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Woo POS] Simultaneous cash and card payment handling
3 participants