Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update empty illustrations #13208

Merged

Conversation

irfano
Copy link
Contributor

@irfano irfano commented Dec 26, 2024

Closes: woocommerce/woomobile-private#379

Description

This PR updates the empty illustrations.

Steps to reproduce

I won’t list all the instructions for every screen; instead, I’ll provide some tips:

  • Use a new, fresh account to view empty screens.
  • Use a Blaze-eligible site to test the Blaze flow. You can search for locations while setting up the campaign.
  • Turn off your device’s internet to see the dashboard card error.

Testing information

Please test both dark mode and light mode.

The tests that have been performed

Tested the screens I shared in the Images/gif.

Images/gif

before after after dark
  • I have considered if this change warrants release notes and have added them to RELEASE-NOTES.txt if necessary. Use the "[Internal]" label for non-user-facing changes.

Reviewer (or Author, in the case of optional code reviews):

Please make sure these conditions are met before approving the PR, or request changes if the PR needs improvement:

  • The PR is small and has a clear, single focus, or a valid explanation is provided in the description. If needed, please request to split it into smaller PRs.
  • Ensure Adequate Unit Test Coverage: The changes are reasonably covered by unit tests or an explanation is provided in the PR description.
  • Manual Testing: The author listed all the tests they ran, including smoke tests when needed (e.g., for refactorings). The reviewer confirmed that the PR works as expected on big (tablet) and small (phone) in case of UI changes, and no regressions are added.

@irfano irfano added the category: design Layout and style elements in the UI or user interface, including color and animations. label Dec 26, 2024
@irfano irfano added this to the 21.6 milestone Dec 26, 2024
@dangermattic
Copy link
Collaborator

1 Warning
⚠️ This PR is larger than 300 lines of changes. Please consider splitting it into smaller PRs for easier and faster reviews.

Generated by 🚫 Danger

@wpmobilebot
Copy link
Collaborator

📲 You can test the changes from this Pull Request in WooCommerce-Wear Android by scanning the QR code below to install the corresponding build.
App Name WooCommerce-Wear Android
Platform⌚️ Wear OS
FlavorJalapeno
Build TypeDebug
Commitd6b84ae
Direct Downloadwoocommerce-wear-prototype-build-pr13208-d6b84ae.apk

@wpmobilebot
Copy link
Collaborator

📲 You can test the changes from this Pull Request in WooCommerce Android by scanning the QR code below to install the corresponding build.

App Name WooCommerce Android
Platform📱 Mobile
FlavorJalapeno
Build TypeDebug
Commitd6b84ae
Direct Downloadwoocommerce-prototype-build-pr13208-d6b84ae.apk

@codecov-commenter
Copy link

codecov-commenter commented Dec 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 40.59%. Comparing base (493e2ca) to head (d6b84ae).
Report is 56 commits behind head on feature/woo-2.0-brand-updates.

Additional details and impacted files
@@                         Coverage Diff                         @@
##             feature/woo-2.0-brand-updates   #13208      +/-   ##
===================================================================
- Coverage                            40.59%   40.59%   -0.01%     
  Complexity                            6372     6372              
===================================================================
  Files                                 1345     1345              
  Lines                                77236    77235       -1     
  Branches                             10602    10602              
===================================================================
- Hits                                 31352    31350       -2     
- Misses                               43136    43137       +1     
  Partials                              2748     2748              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JorgeMucientes JorgeMucientes self-assigned this Dec 30, 2024
@wagveloso
Copy link

wagveloso commented Dec 30, 2024

Hi there. Thanks for sharing the screenshots. The only request is to make the add products button primary on the Upsells and Cross-Sells screens.

Here you find the Figma link:

Thank you!

Copy link
Contributor

@JorgeMucientes JorgeMucientes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job @irfano the new illustration work great!

Just a question outside of scope of this PR. Are there any plans to update this banner as well? The design is really outdated (it even has the old pink color from Woo)

Screenshot 2024-12-31 at 12 26 13

@irfano
Copy link
Contributor Author

irfano commented Jan 2, 2025

Just a question outside of scope of this PR. Are there any plans to update this banner as well? The design is really outdated (it even has the old pink color from Woo)

We still have some outdated colors in the app, and this isn’t the only one. If the illustration doesn’t include a logo, it’s not a blocker, we can update them later.

@irfano irfano merged commit 68c5e31 into feature/woo-2.0-brand-updates Jan 2, 2025
17 of 18 checks passed
@irfano irfano deleted the feature/update-empty-illustrations branch January 2, 2025 23:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: design Layout and style elements in the UI or user interface, including color and animations.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants