-
Notifications
You must be signed in to change notification settings - Fork 130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update empty illustrations #13208
Update empty illustrations #13208
Conversation
Generated by 🚫 Danger |
📲 You can test the changes from this Pull Request in WooCommerce-Wear Android by scanning the QR code below to install the corresponding build.
|
📲 You can test the changes from this Pull Request in WooCommerce Android by scanning the QR code below to install the corresponding build.
|
WooCommerce/src/main/res/drawable-night/img_empty_coupon_list.xml
Dismissed
Show dismissed
Hide dismissed
WooCommerce/src/main/res/drawable-night/img_empty_orders_no_orders.xml
Dismissed
Show dismissed
Hide dismissed
WooCommerce/src/main/res/drawable/img_empty_orders_no_orders.xml
Dismissed
Show dismissed
Hide dismissed
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## feature/woo-2.0-brand-updates #13208 +/- ##
===================================================================
- Coverage 40.59% 40.59% -0.01%
Complexity 6372 6372
===================================================================
Files 1345 1345
Lines 77236 77235 -1
Branches 10602 10602
===================================================================
- Hits 31352 31350 -2
- Misses 43136 43137 +1
Partials 2748 2748 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice job @irfano the new illustration work great!
Just a question outside of scope of this PR. Are there any plans to update this banner as well? The design is really outdated (it even has the old pink color from Woo)
We still have some outdated colors in the app, and this isn’t the only one. If the illustration doesn’t include a logo, it’s not a blocker, we can update them later. |
Closes: woocommerce/woomobile-private#379
Description
This PR updates the empty illustrations.
Steps to reproduce
I won’t list all the instructions for every screen; instead, I’ll provide some tips:
Testing information
Please test both dark mode and light mode.
The tests that have been performed
Tested the screens I shared in the Images/gif.
Images/gif
RELEASE-NOTES.txt
if necessary. Use the "[Internal]" label for non-user-facing changes.Reviewer (or Author, in the case of optional code reviews):
Please make sure these conditions are met before approving the PR, or request changes if the PR needs improvement: