-
Notifications
You must be signed in to change notification settings - Fork 130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable e2eRealApiOrderDetails
UI test
#13066
Conversation
📲 You can test the changes from this Pull Request in WooCommerce-Wear Android by scanning the QR code below to install the corresponding build.
|
📲 You can test the changes from this Pull Request in WooCommerce Android by scanning the QR code below to install the corresponding build.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I manually re-run the test five times both on a phone simulator API 35, and they all pass fine.
However on a tablet simulator (Pixel tablet API 32) it keeps failing. I'm sending you the recording in Slack p1733375323312509-slack-C03L1NF1EA3
Aside:
I was curious if there's a way to do this repeat tests automatically, because in Xcode there is such an option:
(source)
I found an option in Android Studio but its only for JUnit tests:
We only fill the search bar in the e2eRealApiOrdersSearch() function, and it already clears the search bar after filling it. Therefore, it is unnecessary to clear it again in the After function.
Good catch on the tablet issue, Hafiz! I've implemented some fixes:
Please also test
I’m not sure if it’s possible; I always run it manually multiple times. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the update. Tested the new update a few times in tablet and they're running nicely.
Please also test ScreenshotTest and OrdersUITest to ensure these changes don't break them. Note that these tests might still fail on tablets, but they are already failing on the trunk. Fixing those failures is outside the scope of this PR.
Got it. I tested these on phones and they're going fine, I believe that's OK for now.
Description
OrdersRealAPi.e2eRealApiOrderDetails()
was ignored before since it was failing. This test was fixed in #12963 and #12906 before and this PR removesIgnore
annotation from it. I also removed@Retry(numberOfTimes = 1)
from it since it's not flaky.Testing information
Run
OrdersRealAPi.e2eRealApiOrderDetails()
a couple times ti ensure it's passing every time.The tests that have been performed
Ran
OrdersRealAPi.e2eRealApiOrderDetails()
a couple of times.RELEASE-NOTES.txt
if necessary. Use the "[Internal]" label for non-user-facing changes.Reviewer (or Author, in the case of optional code reviews):
Please make sure these conditions are met before approving the PR, or request changes if the PR needs improvement: