-
Notifications
You must be signed in to change notification settings - Fork 130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Product Global Unique Id] Edit and Validate Value #13022
[Product Global Unique Id] Edit and Validate Value #13022
Conversation
📲 You can test the changes from this Pull Request in WooCommerce-Wear Android by scanning the QR code below to install the corresponding build.
|
📲 You can test the changes from this Pull Request in WooCommerce Android by scanning the QR code below to install the corresponding build.
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## trunk #13022 +/- ##
=========================================
Coverage 39.73% 39.74%
- Complexity 6038 6044 +6
=========================================
Files 1274 1274
Lines 73464 73485 +21
Branches 10075 10080 +5
=========================================
+ Hits 29192 29207 +15
Misses 41699 41699
- Partials 2573 2579 +6 ☔ View full report in Codecov by Sentry. |
Closes: #13017
Description
With this PR we let the users update the products and variations global unique identifier. We also validate the value to avoid it to contain characters other than numbers and hyphens.
Steps to reproduce
Duplicated case
Enter a duplicated GTIN value, that is, a value that was assigned before to a product or variation. When saving the product or variation you should see an error coming remotely. (See video)
Testing information
The tests that have been performed
I checked that:
Images/gif
Products
Variations
Validating errors
RELEASE-NOTES.txt
if necessary. Use the "[Internal]" label for non-user-facing changes.Reviewer (or Author, in the case of optional code reviews):
Please make sure these conditions are met before approving the PR, or request changes if the PR needs improvement: