Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix failing ScreenshotTest in TR language #12999

Merged

Conversation

irfano
Copy link
Contributor

@irfano irfano commented Nov 25, 2024

Description

ScreenshotTest was failing due to a bug in the Wiremock library. This PR applies @hichamboushaba suggestion (p1732272671780979/1732209135.456889-slack-CGPNUU63E) as a workaround to this library bug.

Wiremock's DateOffset class was transforming "minutes" to "MİNUTES" when the device language was set to Turkish. Now, we'll convert "minutes" to "MINUTES" before sending it to the library to avoid the issue.

Steps to reproduce

  1. Set device language to Turkish.
  2. Run ScreenshotTest.

The tests that have been performed

Ran ScreenshotTest.

  • I have considered if this change warrants release notes and have added them to RELEASE-NOTES.txt if necessary. Use the "[Internal]" label for non-user-facing changes.

Reviewer (or Author, in the case of optional code reviews):

Please make sure these conditions are met before approving the PR, or request changes if the PR needs improvement:

  • The PR is small and has a clear, single focus, or a valid explanation is provided in the description. If needed, please request to split it into smaller PRs.
  • Ensure Adequate Unit Test Coverage: The changes are reasonably covered by unit tests or an explanation is provided in the PR description.
  • Manual Testing: The author listed all the tests they ran, including smoke tests when needed (e.g., for refactorings). The reviewer confirmed that the PR works as expected on big (tablet) and small (phone) in case of UI changes, and no regressions are added.

@irfano irfano added the category: ui tests Related to UI testing. label Nov 25, 2024
@irfano irfano added this to the 21.2 ❄️ milestone Nov 25, 2024
@irfano irfano requested a review from a team as a code owner November 25, 2024 21:23
@wpmobilebot
Copy link
Collaborator

📲 You can test the changes from this Pull Request in WooCommerce-Wear Android by scanning the QR code below to install the corresponding build.
App Name WooCommerce-Wear Android
Platform⌚️ Wear OS
FlavorJalapeno
Build TypeDebug
Commit72c41bb
Direct Downloadwoocommerce-wear-prototype-build-pr12999-72c41bb.apk

@wpmobilebot
Copy link
Collaborator

📲 You can test the changes from this Pull Request in WooCommerce Android by scanning the QR code below to install the corresponding build.

App Name WooCommerce Android
Platform📱 Mobile
FlavorJalapeno
Build TypeDebug
Commit72c41bb
Direct Downloadwoocommerce-prototype-build-pr12999-72c41bb.apk

Copy link
Member

@hichamboushaba hichamboushaba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hichamboushaba hichamboushaba merged commit ddee367 into release/21.2 Nov 26, 2024
18 of 19 checks passed
@hichamboushaba hichamboushaba deleted the fix/locale-issue-when-parsing-dates-in-testbase branch November 26, 2024 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: ui tests Related to UI testing.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants