Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump Tracks to 5.0.0 #11416

Merged
merged 1 commit into from
Apr 30, 2024
Merged

Bump Tracks to 5.0.0 #11416

merged 1 commit into from
Apr 30, 2024

Conversation

wzieba
Copy link
Contributor

@wzieba wzieba commented Apr 30, 2024

Description

This PR bumps Tracks to 5.0.0 and addresses breaking changes: introduces crashlogging library (extracted from Tracks) and initializes SDK via initialize method.

Testing instructions

Please use CrashLogging#sendReport method somewhere in the code, run build in release variant and verify that the event was sent to the Sentry instance

  • I have considered if this change warrants release notes and have added them to RELEASE-NOTES.txt if necessary. Use the "[Internal]" label for non-user-facing changes.

@wzieba wzieba added the category: tooling Anything that involves building & maintaining the project, including scripts, `Fastfile`, etc. label Apr 30, 2024
@wzieba wzieba added this to the 18.5 milestone Apr 30, 2024
@wzieba wzieba requested review from a team, soundsokay and kidinov and removed request for a team and soundsokay April 30, 2024 07:38
@wzieba
Copy link
Contributor Author

wzieba commented Apr 30, 2024

I see David is AFK - @kidinov are you fine with reviewing this PR? 🙂

@wpmobilebot
Copy link
Collaborator

Found 1 violations:

The PR caused the following dependency changes:

expand

-+--- com.automattic.tracks:experimentation:4.0.2
++--- com.automattic.tracks:experimentation:5.0.0
-\--- com.automattic:Automattic-Tracks-Android:4.0.2
-     +--- io.sentry:sentry-bom:7.5.0
-     |    +--- io.sentry:sentry-android:7.5.0 (c)
-     |    +--- io.sentry:sentry-android-fragment:7.5.0 (c)
-     |    +--- io.sentry:sentry-android-okhttp:7.5.0 (c)
-     |    +--- io.sentry:sentry-android-core:7.5.0 (c)
-     |    +--- io.sentry:sentry-android-ndk:7.5.0 (c)
-     |    +--- io.sentry:sentry:7.5.0 (c)
-     |    \--- io.sentry:sentry-okhttp:7.5.0 (c)
-     +--- io.sentry:sentry-android -> 7.5.0
-     |    +--- io.sentry:sentry-android-core:7.5.0
-     |    |    +--- io.sentry:sentry:7.5.0
-     |    |    +--- androidx.lifecycle:lifecycle-process:2.2.0 -> 2.6.2 (*)
-     |    |    +--- androidx.lifecycle:lifecycle-common-java8:2.2.0 -> 2.6.2
-     |    |    |    +--- androidx.annotation:annotation:1.1.0 -> 1.7.0 (*)
-     |    |    |    +--- androidx.lifecycle:lifecycle-common:2.6.2 (*)
-     |    |    |    +--- androidx.lifecycle:lifecycle-common:2.6.2 (c)
-     |    |    |    +--- androidx.lifecycle:lifecycle-livedata:2.6.2 (c)
-     |    |    |    +--- androidx.lifecycle:lifecycle-livedata-core:2.6.2 (c)
-     |    |    |    +--- androidx.lifecycle:lifecycle-livedata-core-ktx:2.6.2 (c)
-     |    |    |    +--- androidx.lifecycle:lifecycle-livedata-ktx:2.6.2 (c)
-     |    |    |    +--- androidx.lifecycle:lifecycle-process:2.6.2 (c)
-     |    |    |    +--- androidx.lifecycle:lifecycle-runtime:2.6.2 (c)
-     |    |    |    +--- androidx.lifecycle:lifecycle-runtime-ktx:2.6.2 (c)
-     |    |    |    +--- androidx.lifecycle:lifecycle-service:2.6.2 (c)
-     |    |    |    +--- androidx.lifecycle:lifecycle-viewmodel:2.6.2 (c)
-     |    |    |    +--- androidx.lifecycle:lifecycle-viewmodel-compose:2.6.2 (c)
-     |    |    |    +--- androidx.lifecycle:lifecycle-viewmodel-ktx:2.6.2 (c)
-     |    |    |    \--- androidx.lifecycle:lifecycle-viewmodel-savedstate:2.6.2 (c)
-     |    |    \--- androidx.core:core:1.3.2 -> 1.12.0 (*)
-     |    \--- io.sentry:sentry-android-ndk:7.5.0
-     |         +--- io.sentry:sentry:7.5.0
-     |         \--- io.sentry:sentry-android-core:7.5.0 (*)
-     +--- io.sentry:sentry-android-okhttp -> 7.5.0
-     |    +--- io.sentry:sentry:7.5.0
-     |    +--- io.sentry:sentry-okhttp:7.5.0
-     |    |    +--- io.sentry:sentry:7.5.0
-     |    |    \--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.8.0 -> 1.9.10 (*)
-     |    \--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.8.0 -> 1.9.10 (*)
-     +--- io.sentry:sentry-android-fragment -> 7.5.0
-     |    \--- io.sentry:sentry:7.5.0
-     +--- androidx.annotation:annotation:1.1.0 -> 1.7.0 (*)
-     +--- com.squareup.okhttp3:okhttp:4.9.0 -> 4.12.0
-     |    +--- com.squareup.okio:okio:3.6.0
-     |    |    \--- com.squareup.okio:okio-jvm:3.6.0
-     |    |         +--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.9.10 (*)
-     |    |         \--- org.jetbrains.kotlin:kotlin-stdlib-common:1.9.10 -> 1.9.22 (*)
-     |    \--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.8.21 -> 1.9.10 (*)
-     +--- org.jetbrains.kotlinx:kotlinx-coroutines-core:1.6.4 -> 1.7.3 (*)
-     \--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.8.21 -> 1.9.10 (*)
++--- com.automattic:Automattic-Tracks-Android:5.0.0
+     +--- androidx.annotation:annotation:1.1.0 -> 1.7.0 (*)
+     +--- com.squareup.okhttp3:okhttp:4.9.0 -> 4.12.0
+     |    +--- com.squareup.okio:okio:3.6.0
+     |    |    \--- com.squareup.okio:okio-jvm:3.6.0
+     |    |         +--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.9.10 (*)
+     |    |         \--- org.jetbrains.kotlin:kotlin-stdlib-common:1.9.10 -> 1.9.22 (*)
+     |    \--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.8.21 -> 1.9.10 (*)
+     \--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.8.21 -> 1.9.10 (*)
+\--- com.automattic.tracks:crashlogging:5.0.0
+     +--- io.sentry:sentry-bom:7.8.0
+     |    +--- io.sentry:sentry-android:7.8.0 (c)
+     |    +--- io.sentry:sentry-android-fragment:7.8.0 (c)
+     |    +--- io.sentry:sentry-android-okhttp:7.8.0 (c)
+     |    +--- io.sentry:sentry-android-core:7.8.0 (c)
+     |    +--- io.sentry:sentry-android-ndk:7.8.0 (c)
+     |    +--- io.sentry:sentry:7.8.0 (c)
+     |    \--- io.sentry:sentry-okhttp:7.8.0 (c)
+     +--- io.sentry:sentry-android -> 7.8.0
+     |    +--- io.sentry:sentry-android-core:7.8.0
+     |    |    +--- io.sentry:sentry:7.8.0
+     |    |    +--- androidx.lifecycle:lifecycle-process:2.2.0 -> 2.6.2 (*)
+     |    |    +--- androidx.lifecycle:lifecycle-common-java8:2.2.0 -> 2.6.2
+     |    |    |    +--- androidx.annotation:annotation:1.1.0 -> 1.7.0 (*)
+     |    |    |    +--- androidx.lifecycle:lifecycle-common:2.6.2 (*)
+     |    |    |    +--- androidx.lifecycle:lifecycle-common:2.6.2 (c)
+     |    |    |    +--- androidx.lifecycle:lifecycle-livedata:2.6.2 (c)
+     |    |    |    +--- androidx.lifecycle:lifecycle-livedata-core:2.6.2 (c)
+     |    |    |    +--- androidx.lifecycle:lifecycle-livedata-core-ktx:2.6.2 (c)
+     |    |    |    +--- androidx.lifecycle:lifecycle-livedata-ktx:2.6.2 (c)
+     |    |    |    +--- androidx.lifecycle:lifecycle-process:2.6.2 (c)
+     |    |    |    +--- androidx.lifecycle:lifecycle-runtime:2.6.2 (c)
+     |    |    |    +--- androidx.lifecycle:lifecycle-runtime-ktx:2.6.2 (c)
+     |    |    |    +--- androidx.lifecycle:lifecycle-service:2.6.2 (c)
+     |    |    |    +--- androidx.lifecycle:lifecycle-viewmodel:2.6.2 (c)
+     |    |    |    +--- androidx.lifecycle:lifecycle-viewmodel-compose:2.6.2 (c)
+     |    |    |    +--- androidx.lifecycle:lifecycle-viewmodel-ktx:2.6.2 (c)
+     |    |    |    \--- androidx.lifecycle:lifecycle-viewmodel-savedstate:2.6.2 (c)
+     |    |    \--- androidx.core:core:1.3.2 -> 1.12.0 (*)
+     |    \--- io.sentry:sentry-android-ndk:7.8.0
+     |         +--- io.sentry:sentry:7.8.0
+     |         \--- io.sentry:sentry-android-core:7.8.0 (*)
+     +--- io.sentry:sentry-android-okhttp -> 7.8.0
+     |    +--- io.sentry:sentry:7.8.0
+     |    +--- io.sentry:sentry-okhttp:7.8.0
+     |    |    +--- io.sentry:sentry:7.8.0
+     |    |    \--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.8.0 -> 1.9.10 (*)
+     |    \--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.8.0 -> 1.9.10 (*)
+     +--- io.sentry:sentry-android-fragment -> 7.8.0
+     |    \--- io.sentry:sentry:7.8.0
+     +--- androidx.annotation:annotation:1.1.0 -> 1.7.0 (*)
+     +--- com.squareup.okhttp3:okhttp:4.9.0 -> 4.12.0 (*)
+     +--- org.jetbrains.kotlinx:kotlinx-coroutines-core:1.6.4 -> 1.7.3 (*)
+     \--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.8.21 -> 1.9.10 (*)

Please review and act accordingly

@wpmobilebot
Copy link
Collaborator

📲 You can test the changes from this Pull Request in WooCommerce Android by scanning the QR code below to install the corresponding build.

App Name WooCommerce Android
FlavorJalapeno
Build TypeDebug
Commite9083c6
Direct Downloadwoocommerce-prototype-build-pr11416-e9083c6.apk

@kidinov kidinov self-assigned this Apr 30, 2024
Copy link
Contributor

@kidinov kidinov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wzieba 👋

LGTM!

Sentry logging still works
image

JFYI: initialize takes ~10s to run on release build and 40-140ms on debug. If there is anything to optimise inside - would be nice to do so

@kidinov kidinov merged commit 9efc1d4 into trunk Apr 30, 2024
14 of 17 checks passed
@kidinov kidinov deleted the bump_tracks_to_5_0_0 branch April 30, 2024 14:08
@wzieba
Copy link
Contributor Author

wzieba commented Apr 30, 2024

Thanks!

JFYI: initialize takes ~10s to run on release build and 40-140ms on debug. If there is anything to optimise inside - would be nice to do so

initialize calls for SentryAndroid.init (source) - and our part only sets parameters. Before it was done in constructor during DI graph creation. But I'll keep this in mind why debug takes so long - 140ms is definetly much longer than what I'd expect.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: tooling Anything that involves building & maintaining the project, including scripts, `Fastfile`, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants