-
Notifications
You must be signed in to change notification settings - Fork 131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump Tracks to 5.0.0
#11416
Bump Tracks to 5.0.0
#11416
Conversation
I see David is AFK - @kidinov are you fine with reviewing this PR? 🙂 |
Found 1 violations: The PR caused the following dependency changes:expand
-+--- com.automattic.tracks:experimentation:4.0.2
++--- com.automattic.tracks:experimentation:5.0.0
-\--- com.automattic:Automattic-Tracks-Android:4.0.2
- +--- io.sentry:sentry-bom:7.5.0
- | +--- io.sentry:sentry-android:7.5.0 (c)
- | +--- io.sentry:sentry-android-fragment:7.5.0 (c)
- | +--- io.sentry:sentry-android-okhttp:7.5.0 (c)
- | +--- io.sentry:sentry-android-core:7.5.0 (c)
- | +--- io.sentry:sentry-android-ndk:7.5.0 (c)
- | +--- io.sentry:sentry:7.5.0 (c)
- | \--- io.sentry:sentry-okhttp:7.5.0 (c)
- +--- io.sentry:sentry-android -> 7.5.0
- | +--- io.sentry:sentry-android-core:7.5.0
- | | +--- io.sentry:sentry:7.5.0
- | | +--- androidx.lifecycle:lifecycle-process:2.2.0 -> 2.6.2 (*)
- | | +--- androidx.lifecycle:lifecycle-common-java8:2.2.0 -> 2.6.2
- | | | +--- androidx.annotation:annotation:1.1.0 -> 1.7.0 (*)
- | | | +--- androidx.lifecycle:lifecycle-common:2.6.2 (*)
- | | | +--- androidx.lifecycle:lifecycle-common:2.6.2 (c)
- | | | +--- androidx.lifecycle:lifecycle-livedata:2.6.2 (c)
- | | | +--- androidx.lifecycle:lifecycle-livedata-core:2.6.2 (c)
- | | | +--- androidx.lifecycle:lifecycle-livedata-core-ktx:2.6.2 (c)
- | | | +--- androidx.lifecycle:lifecycle-livedata-ktx:2.6.2 (c)
- | | | +--- androidx.lifecycle:lifecycle-process:2.6.2 (c)
- | | | +--- androidx.lifecycle:lifecycle-runtime:2.6.2 (c)
- | | | +--- androidx.lifecycle:lifecycle-runtime-ktx:2.6.2 (c)
- | | | +--- androidx.lifecycle:lifecycle-service:2.6.2 (c)
- | | | +--- androidx.lifecycle:lifecycle-viewmodel:2.6.2 (c)
- | | | +--- androidx.lifecycle:lifecycle-viewmodel-compose:2.6.2 (c)
- | | | +--- androidx.lifecycle:lifecycle-viewmodel-ktx:2.6.2 (c)
- | | | \--- androidx.lifecycle:lifecycle-viewmodel-savedstate:2.6.2 (c)
- | | \--- androidx.core:core:1.3.2 -> 1.12.0 (*)
- | \--- io.sentry:sentry-android-ndk:7.5.0
- | +--- io.sentry:sentry:7.5.0
- | \--- io.sentry:sentry-android-core:7.5.0 (*)
- +--- io.sentry:sentry-android-okhttp -> 7.5.0
- | +--- io.sentry:sentry:7.5.0
- | +--- io.sentry:sentry-okhttp:7.5.0
- | | +--- io.sentry:sentry:7.5.0
- | | \--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.8.0 -> 1.9.10 (*)
- | \--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.8.0 -> 1.9.10 (*)
- +--- io.sentry:sentry-android-fragment -> 7.5.0
- | \--- io.sentry:sentry:7.5.0
- +--- androidx.annotation:annotation:1.1.0 -> 1.7.0 (*)
- +--- com.squareup.okhttp3:okhttp:4.9.0 -> 4.12.0
- | +--- com.squareup.okio:okio:3.6.0
- | | \--- com.squareup.okio:okio-jvm:3.6.0
- | | +--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.9.10 (*)
- | | \--- org.jetbrains.kotlin:kotlin-stdlib-common:1.9.10 -> 1.9.22 (*)
- | \--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.8.21 -> 1.9.10 (*)
- +--- org.jetbrains.kotlinx:kotlinx-coroutines-core:1.6.4 -> 1.7.3 (*)
- \--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.8.21 -> 1.9.10 (*)
++--- com.automattic:Automattic-Tracks-Android:5.0.0
+ +--- androidx.annotation:annotation:1.1.0 -> 1.7.0 (*)
+ +--- com.squareup.okhttp3:okhttp:4.9.0 -> 4.12.0
+ | +--- com.squareup.okio:okio:3.6.0
+ | | \--- com.squareup.okio:okio-jvm:3.6.0
+ | | +--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.9.10 (*)
+ | | \--- org.jetbrains.kotlin:kotlin-stdlib-common:1.9.10 -> 1.9.22 (*)
+ | \--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.8.21 -> 1.9.10 (*)
+ \--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.8.21 -> 1.9.10 (*)
+\--- com.automattic.tracks:crashlogging:5.0.0
+ +--- io.sentry:sentry-bom:7.8.0
+ | +--- io.sentry:sentry-android:7.8.0 (c)
+ | +--- io.sentry:sentry-android-fragment:7.8.0 (c)
+ | +--- io.sentry:sentry-android-okhttp:7.8.0 (c)
+ | +--- io.sentry:sentry-android-core:7.8.0 (c)
+ | +--- io.sentry:sentry-android-ndk:7.8.0 (c)
+ | +--- io.sentry:sentry:7.8.0 (c)
+ | \--- io.sentry:sentry-okhttp:7.8.0 (c)
+ +--- io.sentry:sentry-android -> 7.8.0
+ | +--- io.sentry:sentry-android-core:7.8.0
+ | | +--- io.sentry:sentry:7.8.0
+ | | +--- androidx.lifecycle:lifecycle-process:2.2.0 -> 2.6.2 (*)
+ | | +--- androidx.lifecycle:lifecycle-common-java8:2.2.0 -> 2.6.2
+ | | | +--- androidx.annotation:annotation:1.1.0 -> 1.7.0 (*)
+ | | | +--- androidx.lifecycle:lifecycle-common:2.6.2 (*)
+ | | | +--- androidx.lifecycle:lifecycle-common:2.6.2 (c)
+ | | | +--- androidx.lifecycle:lifecycle-livedata:2.6.2 (c)
+ | | | +--- androidx.lifecycle:lifecycle-livedata-core:2.6.2 (c)
+ | | | +--- androidx.lifecycle:lifecycle-livedata-core-ktx:2.6.2 (c)
+ | | | +--- androidx.lifecycle:lifecycle-livedata-ktx:2.6.2 (c)
+ | | | +--- androidx.lifecycle:lifecycle-process:2.6.2 (c)
+ | | | +--- androidx.lifecycle:lifecycle-runtime:2.6.2 (c)
+ | | | +--- androidx.lifecycle:lifecycle-runtime-ktx:2.6.2 (c)
+ | | | +--- androidx.lifecycle:lifecycle-service:2.6.2 (c)
+ | | | +--- androidx.lifecycle:lifecycle-viewmodel:2.6.2 (c)
+ | | | +--- androidx.lifecycle:lifecycle-viewmodel-compose:2.6.2 (c)
+ | | | +--- androidx.lifecycle:lifecycle-viewmodel-ktx:2.6.2 (c)
+ | | | \--- androidx.lifecycle:lifecycle-viewmodel-savedstate:2.6.2 (c)
+ | | \--- androidx.core:core:1.3.2 -> 1.12.0 (*)
+ | \--- io.sentry:sentry-android-ndk:7.8.0
+ | +--- io.sentry:sentry:7.8.0
+ | \--- io.sentry:sentry-android-core:7.8.0 (*)
+ +--- io.sentry:sentry-android-okhttp -> 7.8.0
+ | +--- io.sentry:sentry:7.8.0
+ | +--- io.sentry:sentry-okhttp:7.8.0
+ | | +--- io.sentry:sentry:7.8.0
+ | | \--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.8.0 -> 1.9.10 (*)
+ | \--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.8.0 -> 1.9.10 (*)
+ +--- io.sentry:sentry-android-fragment -> 7.8.0
+ | \--- io.sentry:sentry:7.8.0
+ +--- androidx.annotation:annotation:1.1.0 -> 1.7.0 (*)
+ +--- com.squareup.okhttp3:okhttp:4.9.0 -> 4.12.0 (*)
+ +--- org.jetbrains.kotlinx:kotlinx-coroutines-core:1.6.4 -> 1.7.3 (*)
+ \--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.8.21 -> 1.9.10 (*)
Please review and act accordingly
|
📲 You can test the changes from this Pull Request in WooCommerce Android by scanning the QR code below to install the corresponding build.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@wzieba 👋
LGTM!
JFYI: initialize
takes ~10s to run on release build and 40-140ms on debug. If there is anything to optimise inside - would be nice to do so
Thanks!
|
Description
This PR bumps Tracks to
5.0.0
and addresses breaking changes: introducescrashlogging
library (extracted from Tracks) and initializes SDK viainitialize
method.Testing instructions
Please use
CrashLogging#sendReport
method somewhere in the code, run build in release variant and verify that the event was sent to the Sentry instanceRELEASE-NOTES.txt
if necessary. Use the "[Internal]" label for non-user-facing changes.