Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Better Errors] Application password tutorial tracks #11265

Merged
merged 5 commits into from
Apr 9, 2024

Conversation

ThomazFB
Copy link
Contributor

@ThomazFB ThomazFB commented Apr 9, 2024

Summary

Fix issue #10805 by introducing the Application Password Tutorial tracks events.

Name Properties When
*_login_site_credentials_invalid_login_page_detected When the app detects that there is an invalid login page and can't log in natively
*_login_site_credentials_app_password_explanation_dismissed When the user chooses to tap back on the app passwords explanation screen
*_login_site_credentials_app_password_explanation_contact_support_tapped When the user chooses to contact support on the app passwords explanation screen
*_login_site_credentials_app_password_explanation_continue_button_tapped When the user chooses to continue to log in with app passwords on the app password explanation screen.
*_login_site_credentials_app_password_login_exit_confirmation When the user tries to exit the app password login page without approving the app password first
*_login_site_credentials_app_password_login_dismissed When the user exists the app passwords login page after confirmation

Update release notes:

  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@ThomazFB ThomazFB added type: task An internally driven task. category: tracks Related to analytics, including Tracks Events. feature: login Related to any part of the log in or sign in flow, or authentication. labels Apr 9, 2024
@dangermattic
Copy link
Collaborator

dangermattic commented Apr 9, 2024

1 Warning
⚠️ PR is not assigned to a milestone.
1 Message
📖

This PR contains changes to Tracks-related logic. Please ensure (author and reviewer) the following are completed:

  • The tracks events must be validated in the Tracks system.
  • Verify the internal Tracks spreadsheet has also been updated.
  • Please consider registering any new events.
  • The PR must be assigned the category: tracks label.

Generated by 🚫 Danger

@ThomazFB ThomazFB marked this pull request as ready for review April 9, 2024 11:23
@ThomazFB ThomazFB linked an issue Apr 9, 2024 that may be closed by this pull request
@wpmobilebot
Copy link
Collaborator

📲 You can test the changes from this Pull Request in WooCommerce Android by scanning the QR code below to install the corresponding build.

App Name WooCommerce Android
FlavorJalapeno
Build TypeDebug
Commitd108fdb
Direct Downloadwoocommerce-prototype-build-pr11265-d108fdb.apk

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 37.50000% with 10 lines in your changes are missing coverage. Please review.

Project coverage is 41.65%. Comparing base (c48183b) to head (d108fdb).

Files Patch % Lines
...onpassword/ApplicationPasswordTutorialViewModel.kt 0.00% 9 Missing ⚠️
...n/sitecredentials/LoginSiteCredentialsViewModel.kt 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##              trunk   #11265      +/-   ##
============================================
- Coverage     41.65%   41.65%   -0.01%     
  Complexity     5208     5208              
============================================
  Files          1053     1053              
  Lines         61283    61298      +15     
  Branches       8370     8370              
============================================
+ Hits          25525    25531       +6     
- Misses        33470    33479       +9     
  Partials       2288     2288              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ThomazFB ThomazFB merged commit 81cf865 into trunk Apr 9, 2024
14 checks passed
@ThomazFB ThomazFB deleted the issue/application-password-tracks branch April 9, 2024 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: tracks Related to analytics, including Tracks Events. feature: login Related to any part of the log in or sign in flow, or authentication. type: task An internally driven task.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Better Errors] Add Site Credential Tracking
4 participants