Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Better Errors] Connectivity tool design review #11258

Merged
merged 17 commits into from
Apr 8, 2024

Conversation

ThomazFB
Copy link
Contributor

@ThomazFB ThomazFB commented Apr 8, 2024

Summary

Fix issue #11109 by adjusting the Connectivity Tool UI to follow the recent design suggestions.

Image

Screen Capture

Success scenario

Screen_recording_20240408_172423.mp4

Failure scenario

Screen_recording_20240408_173108.mp4

Update release notes:

  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@ThomazFB ThomazFB added type: task An internally driven task. feature: order list Related to the order list. labels Apr 8, 2024
@ThomazFB ThomazFB linked an issue Apr 8, 2024 that may be closed by this pull request
4 tasks
@dangermattic
Copy link
Collaborator

dangermattic commented Apr 8, 2024

3 Warnings
⚠️ This PR is larger than 300 lines of changes. Please consider splitting it into smaller PRs for easier and faster reviews.
⚠️ Class ViewState is missing tests, but unit-tests-exemption label was set to ignore this.
⚠️ PR is not assigned to a milestone.

Generated by 🚫 Danger

@ThomazFB ThomazFB marked this pull request as ready for review April 8, 2024 20:34
@wpmobilebot
Copy link
Collaborator

📲 You can test the changes from this Pull Request in WooCommerce Android by scanning the QR code below to install the corresponding build.

App Name WooCommerce Android
FlavorJalapeno
Build TypeDebug
Commit336de06
Direct Downloadwoocommerce-prototype-build-pr11258-336de06.apk

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 58.49057% with 22 lines in your changes are missing coverage. Please review.

Project coverage is 41.23%. Comparing base (8525bae) to head (336de06).
Report is 21 commits behind head on trunk.

Files Patch % Lines
...connectivitytool/OrderConnectivityToolViewModel.kt 45.00% 21 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##              trunk   #11258   +/-   ##
=========================================
  Coverage     41.23%   41.23%           
+ Complexity     5170     5167    -3     
=========================================
  Files          1052     1052           
  Lines         61168    61203   +35     
  Branches       8361     8366    +5     
=========================================
+ Hits          25223    25240   +17     
- Misses        33686    33703   +17     
- Partials       2259     2260    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ThomazFB ThomazFB merged commit c48183b into trunk Apr 8, 2024
19 checks passed
@ThomazFB ThomazFB deleted the issue/connectivity-tool-design-review branch April 8, 2024 22:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature: order list Related to the order list. type: task An internally driven task. unit-tests-exemption
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Better Errors] Connectivity Tool design adjustment
4 participants