Skip to content

Commit

Permalink
Merge pull request #13203 from woocommerce/12957-mobile-payments-cras…
Browse files Browse the repository at this point in the history
…h-when-shop-managers-tries-to-installactivate-woopayments

[Woo POS] Crash when plugin either attempted to be installed or activated by a show manager
  • Loading branch information
kidinov authored Dec 27, 2024
2 parents 16cc17a + aa27885 commit 9a2b63d
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 7 deletions.
1 change: 1 addition & 0 deletions RELEASE-NOTES.txt
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
21.4
-----
- [*] Fixed overlap issue in Settings > WooCommerce Version [https://github.com/woocommerce/woocommerce-android/pull/13183]
- [**] Fixed a crash when a shop manager was trying to install or activate plugin in the POS onboarding [https://github.com/woocommerce/woocommerce-android/pull/13203]


21.3
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ class WooPosCardReaderActivity : AppCompatActivity(R.layout.activity_woo_pos_car
private fun setupTopAndBottomInsets() {
window.navigationBarColor = ContextCompat.getColor(this, android.R.color.transparent)
WindowCompat.setDecorFitsSystemWindows(window, false)
val rootView = findViewById<View>(R.id.root)
val rootView = findViewById<View>(R.id.snack_root)
ViewCompat.setOnApplyWindowInsetsListener(rootView) { view, insets ->
insets.toWindowInsets()?.let { windowInsets ->
val insetsCompat = WindowInsetsCompat.toWindowInsetsCompat(windowInsets, view)
Expand Down
Original file line number Diff line number Diff line change
@@ -1,12 +1,8 @@
<androidx.coordinatorlayout.widget.CoordinatorLayout xmlns:android="http://schemas.android.com/apk/res/android"
xmlns:app="http://schemas.android.com/apk/res-auto"
android:id="@+id/root"
android:id="@+id/snack_root"
android:layout_width="match_parent"
android:layout_height="match_parent"
app:layout_constraintBottom_toTopOf="@+id/trial_bar"
app:layout_constraintEnd_toEndOf="parent"
app:layout_constraintStart_toStartOf="parent"
app:layout_constraintTop_toTopOf="parent">
android:layout_height="match_parent">

<androidx.fragment.app.FragmentContainerView
android:id="@+id/woopos_card_reader_nav_host_fragment"
Expand Down

0 comments on commit 9a2b63d

Please sign in to comment.