This repository has been archived by the owner on Jul 12, 2024. It is now read-only.
Fix hidden menu title on smaller screens #6562
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joelclimbsthings
approved these changes
Mar 10, 2021
|
Thanks, @joelclimbsthings! I see the font-size as 13px, do you see something different? I think that is the expected size ( WordPress/gutenberg#26338 ). Hopefully this remains the same between GB and the WC nav so the experience between the two is not too jarring (assuming WP core implements the nav at some point). |
|
Right! Thanks for the reference. Looks good, then! 🚢 |
ObliviousHarmony
pushed a commit
to woocommerce/woocommerce
that referenced
this pull request
Mar 18, 2022
…in#6562) * Fix hidden menu title on smaller screens * Add changelog entry and testing instructions
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6395
Fixes the menu being hidden when the viewport height is too small.
I tested this with the
hasSearchprop as well and search seemed to be styled correctly. cc @Copons to make sure I haven't broken anything in WordPress/gutenberg#25315 in case we opt to use this feature in the future. Is there a reason for theoverflow: hidden;on the title?Screenshots
Before
After
Detailed test instructions: