This repository has been archived by the owner on Jul 12, 2024. It is now read-only.
Fix Missing Button Colors #5470
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Testing well for me 🚀 Looks like we still have a flaky e2e test but its unrelated to these changes |
samueljseay
approved these changes
Oct 24, 2020
|
Thanks @samueljseay ! I'll take a look at the failing e2e test since it's blocking this merge. |
adrianduffell
added
status: blocked
|
The e2e is now passing in Travis. I also wasn't able to reproduce it locally. I think we can ignore it for now. A new Travis issue has surfaced with PHP tests failing under Composer v2. Marking this as blocked until PR #5462 lands. |
The <Button> component styles from @wordpress/components were missing color styles. This is due to a change in @wordpress/base-styles where a different technique for providing the default button colors was implemented in WordPress/gutenberg#24408. As a temporary measure, this restores the previous code by copying it here directly.
adrianduffell
force-pushed
the
fix/ghost-buttons
branch
from
29dd4c1 to
bf39e0a
Compare
|
@adrianduffell I think we may want to close this one in favor of #5491 |
|
@samueljseay agreed, the other PR looks like a better solution. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5345
The
<Button>component from@wordpress/componentswas missing color styles. This is related to a change in@wordpress/base-styleswhere a different technique for providing the default button colors was implemented in WordPress/gutenberg#24408.As a temporary measure, this PR restores the previous code by copying it directly to the project’s SCSS. The change in
@wordpress/base-stylesis intended to be investigated further at a later date.Detailed test instructions:
Ensure your WordPress profile is using the default admin color scheme.
Start the Onboarding Wizard. Confirm the
Continuebutton is white text on blue background.Go to the WooCommerce home screen. Confirm the notes have action buttons with a blue border, blue text, and transparent background.
