-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(deps): bump ws and @wordpress/scripts #462
Conversation
Bumps [ws](https://github.com/websockets/ws) to 8.18.0 and updates ancestor dependency [@wordpress/scripts](https://github.com/WordPress/gutenberg/tree/HEAD/packages/scripts). These dependencies need to be updated together. Updates `ws` from 8.13.0 to 8.18.0 - [Release notes](https://github.com/websockets/ws/releases) - [Commits](websockets/ws@8.13.0...8.18.0) Updates `@wordpress/scripts` from 27.9.0 to 29.0.0 - [Release notes](https://github.com/WordPress/gutenberg/releases) - [Changelog](https://github.com/WordPress/gutenberg/blob/trunk/packages/scripts/CHANGELOG.md) - [Commits](https://github.com/WordPress/gutenberg/commits/@wordpress/[email protected]/packages/scripts) --- updated-dependencies: - dependency-name: ws dependency-type: indirect - dependency-name: "@wordpress/scripts" dependency-type: direct:development ... Signed-off-by: dependabot[bot] <[email protected]>
The following labels could not be found: |
Since |
@dkotter Should we request a review from the QA team? |
I think because E2E tests are passing here, this is probably something an engineer needs to look at since QA will more than likely test the same things those tests are doing. We just need to verify nothing in our codebase relies on functionality specific to versions of WordPress less than 6.6 (like JSX integrations as Peter mentions) |
@dkotter looks like this is sitting in your queue... are you expecting to do more work here, should this be passed to an engineer to review the codebase, or can it be passed along our project board queues? |
I think my comment here is still valid. E2E tests are passing here but I believe having an actual person test functionality would be best, to ensure nothing breaks in WordPress 6.5. This is probably fine to just move to Regression Testing and handle that there |
I tested this PR on WordPress v6.5.5 and the plugin appears to be functioning as expected. I did not place all kinds of orders (as per E2E) as they do not seem affected by the PR. Below are the login credentials:
|
Bumps ws to 8.18.0 and updates ancestor dependency @wordpress/scripts. These dependencies need to be updated together.
Updates
ws
from 8.13.0 to 8.18.0Release notes
Sourced from ws's releases.
... (truncated)
Commits
976c53c
[dist] 8.18.059b9629
[feature] Add support forBlob
(#2229)0d1b5e6
[security] Use more descriptive text for 2017 vulnerability link15f11a0
[security] Add new DoS vulnerability to SECURITY.md3c56601
[dist] 8.17.1e55e510
[security] Fix crash when the Upgrade header cannot be read (#2231)6a00029
[test] Increase code coverageddfe4a8
[perf] Reduce the amount ofcrypto.randomFillSync()
callsb73b118
[dist] 8.17.029694a5
[test] Use thehighWaterMark
variableUpdates
@wordpress/scripts
from 27.9.0 to 29.0.0Changelog
Sourced from
@wordpress/scripts
's changelog.Commits
c90d920
chore(release): publish2d989d3
Update changelog files2dbed20
Merge changes published in the Gutenberg plugin "release/19.2" branchab95649
chore(release): publishc63e6e9
Update changelog files4510582
Merge changes published in the Gutenberg plugin "release/19.1" branchc3101ab
chore(release): publish4bb3aa7
Update changelog files363edb3
chore(release): publish4985329
Update changelog filesYou can trigger a rebase of this PR by commenting
@dependabot rebase
.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebase
will rebase this PR@dependabot recreate
will recreate this PR, overwriting any edits that have been made to it@dependabot merge
will merge this PR after your CI passes on it@dependabot squash and merge
will squash and merge this PR after your CI passes on it@dependabot cancel merge
will cancel a previously requested merge and block automerging@dependabot reopen
will reopen this PR if it is closed@dependabot close
will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditions
will show all of the ignore conditions of the specified dependency@dependabot ignore this major version
will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor version
will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependency
will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)You can disable automated security fix PRs for this repo from the Security Alerts page.