Refine the vertical gap for Section
component
#2747
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this Pull Request:
This is one of the preliminaries for the shipping Improvements.
Considering the way the
Section
component is used, it can be summarized:VerticalGapLayout
or by additional CSS.Therefore, it should be possible to lift the vertical layout and gap to the
Section
component instead of the above implementation.To avoid too many file changes for subsequent PRs, this PR refines the vertical gap for
Section
component:Section
component.VerticalGapLayout
layers that are no longer needed.'xlarge'
value from the size prop ofVerticalGapLayout
component.💡 I will likely skip code review since this PR only includes developer-facing change.
Detailed test instructions:
Compare before and after this change to check if the following pages are visually consistent in their layout:
Changelog entry