Fix Budget Recommendation data not populating on install #2732
+91
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this Pull Request:
This PR fixes an issue that was introduced in PHP 8.4 compatibility code.
The budget recommendation was covered by unit testing, although it used mocked data, so it didn't catch the testing of actually installing the database table. Since we have database tables available during unit testing I added two types of tests:
Closes #2730
Detailed test instructions:
wp_gla_budget_recommendations
is created and contains rows of imported dataAlternative way to test:
wp_gla_budget_recommendations
add_filter( 'woocommerce_gla_force_run_install', '__return_true' );
Changelog entry